From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-123742-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 80530 invoked by alias); 23 Jun 2015 15:32:26 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 80521 invoked by uid 89); 23 Jun 2015 15:32:25 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_05,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout24.012.net.il
Received: from mtaout24.012.net.il (HELO mtaout24.012.net.il) (80.179.55.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 23 Jun 2015 15:32:24 +0000
Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NQE00J00LF29O00@mtaout24.012.net.il> for gdb-patches@sourceware.org; Tue, 23 Jun 2015 18:23:50 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NQE00FHPLFPYF30@mtaout24.012.net.il>; Tue, 23 Jun 2015 18:23:50 +0300 (IDT)
Date: Tue, 23 Jun 2015 15:32:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 2/5] btrace: support Intel(R) Processor Trace
In-reply-to: <1435047418-21611-3-git-send-email-markus.t.metzger@intel.com>
To: Markus Metzger <markus.t.metzger@intel.com>
Cc: palves@redhat.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83616eh24l.fsf@gnu.org>
References: <1435047418-21611-1-git-send-email-markus.t.metzger@intel.com> <1435047418-21611-3-git-send-email-markus.t.metzger@intel.com>
X-IsSubscribed: yes
X-SW-Source: 2015-06/txt/msg00477.txt.bz2

> From: Markus Metzger <markus.t.metzger@intel.com>
> Cc: gdb-patches@sourceware.org
> Date: Tue, 23 Jun 2015 10:16:55 +0200
> 
> Adds a new command "record btrace pt" to configure the kernel to use
> Intel(R) Processor Trace instead of Branch Trace Strore.
> 
> The "record btrace" command chooses the tracing format automatically.
> 
> Intel Processor Trace support requires kernel 4.1 and libipt.

The documentation parts are OK, with one comment:

> +If @var{size} is a positive number, then @value{GDBN} will try to
> +allocate a buffer of at least @var{size} bytes for each new thread
> +that uses the btrace recording method and the Intel(R) Processor Trace
> +format.  The actually obtained buffer size may differ from the
> +requested @var{size}. Use the @code{info record} command to see the
                       ^^
Two spaces here.

Thanks.