From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30266 invoked by alias); 28 Dec 2014 03:38:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30240 invoked by uid 89); 28 Dec 2014 03:38:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout23.012.net.il Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 28 Dec 2014 03:38:30 +0000 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NH900K00VKCJX00@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Sun, 28 Dec 2014 05:38:27 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NH900K3OWS2GA70@a-mtaout23.012.net.il>; Sun, 28 Dec 2014 05:38:27 +0200 (IST) Date: Sun, 28 Dec 2014 03:38:00 -0000 From: Eli Zaretskii Subject: Re: File-name completer marks all files as executable on MS-Windows In-reply-to: To: Andrew Pinski Cc: chet.ramey@case.edu, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <8361cwl9zy.fsf@gnu.org> References: <83egrklxde.fsf@gnu.org> X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg00648.txt.bz2 > Date: Sat, 27 Dec 2014 14:00:45 -0800 > From: Andrew Pinski > Cc: Chet Ramey , > "gdb-patches@sourceware.org" > > On Sat, Dec 27, 2014 at 11:13 AM, Eli Zaretskii wrote: > > I discovered that completing on file names in GDB on MS-Windows marks > > every file as executable. This is because Readline uses 'access' and > > X_OK to determine that, which doesn't work on Windows. > > > > Suggested patch is below. > > Has this gone upstream to readline? Maybe it should go upstream first. That's why I CC'ed Chet.