From: Eli Zaretskii <eliz@gnu.org>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Allow explicit 16 or 32 char in 'x /s'
Date: Thu, 18 Mar 2010 18:26:00 -0000 [thread overview]
Message-ID: <83634tv64q.fsf@gnu.org> (raw)
In-Reply-To: <001e01cac69a$75167630$5f436290$%muller@ics-cnrs.unistra.fr>
> From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
> Cc: <gdb-patches@sourceware.org>
> Date: Thu, 18 Mar 2010 13:56:42 +0100
>
> > > The patch below allows to
> > > print strings that are made of 16 bit or 32 bit char
> > > using:
> > > 'x /hs ' or 'x /ws ' commands.
> >
> > Thanks. If this patch is accepted, we will need a suitable change for
> > the manual.
>
> How about this change?
It's okay, but it needs a few fixes:
> doc/ChangeLog entry:
>
> 2010-03-18 Pierre Muller <muller@ics.u-strasbg.fr>
>
> * gdbint.texinfo (Examining memory): Update for
gdb.texinfo, not gdbint.texinfo.
> +default unit the next time you use @code{x}. For the @samp{i} format,
^^
Two spaces between sentences (here and elsewhere in your patch).
> +Ue @code{x /hs} to display 16-bit char strings and @code{x /ws} to display
Suggest to rephrase
Use @kbd{x /hs} to display strings made of 16-bid wide characters
and similarly for x/ws.
> +32-bit strings. The next use of @code{x /s} will still display 8-bit
^^^^^
I suggest "again" instead of "still"
Okay with these changes.
Thanks.
next prev parent reply other threads:[~2010-03-18 18:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 22:43 Pierre Muller
2010-03-18 7:01 ` Eli Zaretskii
2010-03-18 14:20 ` Pierre Muller
[not found] ` <001e01cac69a$75167630$5f436290$%muller@ics-cnrs.unistra.fr>
2010-03-18 18:26 ` Eli Zaretskii [this message]
[not found] <11484.4708740295$1268865815@news.gmane.org>
2010-03-18 22:08 ` Tom Tromey
2010-03-19 7:32 ` Eli Zaretskii
2010-03-22 22:54 ` Pierre Muller
[not found] ` <15103.6087111153$1269298497@news.gmane.org>
2010-03-30 20:33 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83634tv64q.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).