From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-71235-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15617 invoked by alias); 18 Mar 2010 18:26:23 -0000
Received: (qmail 15607 invoked by uid 22791); 18 Mar 2010 18:26:21 -0000
X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 	tests=AWL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 18 Mar 2010 18:26:12 +0000
Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0KZH00B00PSHOO00@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Thu, 18 Mar 2010 20:25:43 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.70.182.236]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KZH00AF7PUUQN40@a-mtaout23.012.net.il>; Thu, 18 Mar 2010 20:25:43 +0200 (IST)
Date: Thu, 18 Mar 2010 18:26:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFC] Allow explicit 16 or 32 char in 'x /s'
In-reply-to: <001e01cac69a$75167630$5f436290$%muller@ics-cnrs.unistra.fr>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83634tv64q.fsf@gnu.org>
References: <000f01cac623$2ec3a850$8c4af8f0$%muller@ics-cnrs.unistra.fr> <E1Ns9je-0003cA-V7@fencepost.gnu.org> <001e01cac69a$75167630$5f436290$%muller@ics-cnrs.unistra.fr>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-03/txt/msg00680.txt.bz2

> From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
> Cc: <gdb-patches@sourceware.org>
> Date: Thu, 18 Mar 2010 13:56:42 +0100
> 
> > >   The patch below allows to
> > > print strings that are made of 16 bit or 32 bit char
> > > using:
> > > 'x /hs ' or 'x /ws ' commands.
> > 
> > Thanks.  If this patch is accepted, we will need a suitable change for
> > the manual.
> 
> How about this change?

It's okay, but it needs a few fixes:

> doc/ChangeLog entry:
> 
> 2010-03-18  Pierre Muller  <muller@ics.u-strasbg.fr>
> 
>       * gdbint.texinfo (Examining memory): Update for

gdb.texinfo, not gdbint.texinfo.

> +default unit the next time you use @code{x}. For the @samp{i} format,
                                              ^^
Two spaces between sentences (here and elsewhere in your patch).

> +Ue @code{x /hs} to display 16-bit char strings and @code{x /ws} to display

Suggest to rephrase

  Use @kbd{x /hs} to display strings made of 16-bid wide characters

and similarly for x/ws.

> +32-bit strings. The next use of @code{x /s} will still display 8-bit
                                                    ^^^^^
I suggest "again" instead of "still"

Okay with these changes.

Thanks.