From: Eli Zaretskii <eliz@gnu.org>
To: Shahab Vahedi <shahab.vahedi@gmail.com>
Cc: gdb-patches@sourceware.org, shahab@synopsys.com,
simark@simark.ca, tom@tromey.com, anton.kolesov@synopsys.com,
fbedard@synopsys.com
Subject: Re: [PATCH v6 1/4] arc: Add ARCv2 XML target along with refactoring
Date: Wed, 05 Aug 2020 17:31:14 +0300 [thread overview]
Message-ID: <837dud9nbh.fsf@gnu.org> (raw)
In-Reply-To: <20200805110934.6225-2-shahab.vahedi@gmail.com> (message from Shahab Vahedi on Wed, 5 Aug 2020 13:09:31 +0200)
> From: Shahab Vahedi <shahab.vahedi@gmail.com>
> Cc: Shahab Vahedi <shahab.vahedi@gmail.com>,
> Shahab Vahedi <shahab@synopsys.com>,
> Simon Marchi <simark@simark.ca>,
> Tom Tromey <tom@tromey.com>,
> Eli Zaretskii <eliz@gnu.org>,
> Anton Kolesov <anton.kolesov@synopsys.com>,
> Francois Bedard <fbedard@synopsys.com>
> Date: Wed, 5 Aug 2020 13:09:31 +0200
>
> gdb/ChangeLog:
>
> * arch/arc.h
> (arc_gdbarch_features): New class to stir the selection of target XML.
> (arc_create_target_description): Use FEATURES to choose XML target.
> (arc_lookup_target_description): Use arc_create_target_description
> to create _new_ target descriptions or return the already created
> ones if the FEATURES is the same.
> * arch/arc.c: Implementation of prototypes described above.
> * gdb/arc-tdep.h (arc_regnum enum): Add more registers.
> (arc_gdbarch_features_init): Initialize the FEATURES struct.
> * arc-tdep.c (*_feature_name): Make feature names consistent.
> (arc_register_feature): A new struct to hold information about
> registers of a particular target/feature.
> (arc_check_tdesc_feature): Check if XML provides registers in
> compliance with ARC_REGISTER_FEATURE structs.
> (arc_update_acc_reg_names): Add aliases for r58 and r59.
> (determine_*_reg_feature_set): Which feature name to look for.
> (arc_gdbarch_features_init): Given MACH and ABFD, initialize FEATURES.
> (mach_type_to_arc_isa): Convert from a set of binutils machine types
> to expected ISA enums to be used in arc_gdbarch_features structs.
> * features/Makefile (FEATURE_XMLFILES): Add new files.
> * gdb/features/arc/v1-aux.c: New file.
> * gdb/features/arc/v1-aux.xml: Likewise.
> * gdb/features/arc/v1-core.c: Likewise.
> * gdb/features/arc/v1-core.xml: Likewise.
> * gdb/features/arc/v2-aux.c: Likewise.
> * gdb/features/arc/v2-aux.xml: Likewise.
> * gdb/features/arc/v2-core.c: Likewise.
> * gdb/features/arc/v2-core.xml: Likewise.
> * NEWS (Changes since GDB 9): Announce obsolence of old feature names.
>
> gdb/doc/ChangeLog:
>
> * gdb.texinfo (Synopsys ARC): Update the documentation for ARC Features.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.arch/arc-tdesc-cpu.xml: Use new feature names.
The documentation parts are OK, with this single nit:
> +existence depends on the configuration. When debugging GNU/Linux applications,
> +i.e. user space debugging, these core registers are not available.
Please use "i.e.@:", so that the second period is not taken as ending
the sentence (which makes a difference in the printed version of the
manual).
Thanks.
next prev parent reply other threads:[~2020-08-05 14:31 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 12:52 [PATCH 0/4] arc: Add GNU/Linux support Shahab Vahedi
2020-03-26 12:52 ` [PATCH 1/4] arc: Add XML target features for Linux targets Shahab Vahedi
2020-04-24 13:46 ` Tom Tromey
2020-03-26 12:52 ` [PATCH 2/4] arc: Recognize registers available on " Shahab Vahedi
2020-04-24 13:50 ` Tom Tromey
2020-03-26 12:52 ` [PATCH 3/4] arc: Add GNU/Linux support for ARC Shahab Vahedi
2020-04-24 14:00 ` Tom Tromey
2020-03-26 12:52 ` [PATCH 4/4] arc: Add arc-*-linux regformats Shahab Vahedi
2020-04-24 14:01 ` Tom Tromey
2020-04-06 9:13 ` [PING][PATCH 0/4] arc: Add GNU/Linux support Shahab Vahedi
2020-04-20 16:51 ` [PING^2][PATCH " Shahab Vahedi
2020-04-28 16:04 ` [PATCH v2 " Shahab Vahedi
2020-04-28 16:04 ` [PATCH v2 1/4] arc: Add XML target features for Linux targets Shahab Vahedi
2020-05-14 14:49 ` Simon Marchi
2020-04-28 16:04 ` [PATCH v2 2/4] arc: Recognize registers available on " Shahab Vahedi
2020-04-28 16:56 ` Eli Zaretskii
2020-05-14 15:01 ` Simon Marchi
2020-06-17 15:46 ` Shahab Vahedi
2020-07-13 15:48 ` Simon Marchi
2020-07-14 9:05 ` Shahab Vahedi
2020-04-28 16:04 ` [PATCH v2 3/4] arc: Add GNU/Linux support for ARC Shahab Vahedi
2020-05-14 15:09 ` Simon Marchi
2020-06-15 23:13 ` Shahab Vahedi
2020-06-16 0:58 ` Simon Marchi
2020-04-28 16:04 ` [PATCH v2 4/4] arc: Add arc-*-linux regformats Shahab Vahedi
2020-05-14 15:12 ` Simon Marchi
2020-06-15 23:37 ` Shahab Vahedi
2020-06-16 2:08 ` Simon Marchi
2020-05-14 11:43 ` [PATCH v2 0/4] arc: Add GNU/Linux support Shahab Vahedi
2020-07-13 15:45 ` [PATCH v3 0/3] " Shahab Vahedi
2020-07-13 15:45 ` [PATCH v3 1/3] arc: Add ARCv2 XML target along with refactoring Shahab Vahedi
2020-07-15 2:52 ` Simon Marchi
2020-07-15 20:35 ` Shahab Vahedi
2020-07-15 21:23 ` Christian Biesinger
2020-07-16 1:59 ` Simon Marchi
2020-07-16 13:28 ` Simon Marchi
2020-07-22 13:36 ` Shahab Vahedi
2020-07-22 13:49 ` Simon Marchi
2020-07-22 14:33 ` Shahab Vahedi
2020-07-22 14:54 ` Simon Marchi
2020-07-13 15:45 ` [PATCH v3 2/3] arc: Add hardware loop detection Shahab Vahedi
2020-07-15 2:55 ` Simon Marchi
2020-07-13 15:45 ` [PATCH v3 3/3] arc: Add GNU/Linux support for ARC Shahab Vahedi
2020-07-15 3:03 ` Simon Marchi
2020-07-23 19:35 ` [PATCH v4 0/3] arc: Add GNU/Linux support Shahab Vahedi
2020-07-23 19:35 ` [PATCH v4 1/3] arc: Add ARCv2 XML target along with refactoring Shahab Vahedi
2020-07-30 23:34 ` Simon Marchi
2020-07-23 19:35 ` [PATCH v4 2/3] arc: Add hardware loop detection Shahab Vahedi
2020-08-01 14:53 ` Simon Marchi
2020-07-23 19:35 ` [PATCH v4 3/3] arc: Add GNU/Linux support for ARC Shahab Vahedi
2020-08-01 15:01 ` Simon Marchi
2020-08-01 23:31 ` [PATCH v4 0/3] arc: Add GNU/Linux support Simon Marchi
2020-08-04 7:59 ` Shahab Vahedi
2020-08-04 12:42 ` Simon Marchi
2020-08-04 8:57 ` [PATCH v5 0/4] " Shahab Vahedi
2020-08-04 8:57 ` [PATCH v5 1/4] arc: Add ARCv2 XML target along with refactoring Shahab Vahedi
2020-08-04 13:08 ` Simon Marchi
2020-08-04 13:18 ` Shahab Vahedi
2020-08-04 13:20 ` Simon Marchi
2020-08-04 14:12 ` Shahab Vahedi
2020-08-04 8:57 ` [PATCH v5 2/4] arc: Add inclusion of "gdbarch.h" in "arc-tdep.h" Shahab Vahedi
2020-08-04 8:57 ` [PATCH v5 3/4] arc: Add hardware loop detection Shahab Vahedi
2020-08-04 14:28 ` Eli Zaretskii
2020-08-04 16:17 ` Shahab Vahedi
2020-08-04 16:42 ` Eli Zaretskii
2020-08-04 18:15 ` Shahab Vahedi
2020-08-04 8:57 ` [PATCH v5 4/4] arc: Add GNU/Linux support for ARC Shahab Vahedi
2020-08-04 12:49 ` [PATCH v5 0/4] arc: Add GNU/Linux support Simon Marchi
2020-08-04 13:05 ` Shahab Vahedi
2020-08-05 11:09 ` [PATCH v6 " Shahab Vahedi
2020-08-05 11:09 ` [PATCH v6 1/4] arc: Add ARCv2 XML target along with refactoring Shahab Vahedi
2020-08-05 14:31 ` Eli Zaretskii [this message]
2020-08-21 16:16 ` Simon Marchi
2020-08-24 20:14 ` Shahab Vahedi
2020-08-05 11:09 ` [PATCH v6 2/4] arc: Add inclusion of "gdbarch.h" in "arc-tdep.h" Shahab Vahedi
2020-08-05 11:09 ` [PATCH v6 3/4] arc: Add hardware loop detection Shahab Vahedi
2020-08-05 11:09 ` [PATCH v6 4/4] arc: Add GNU/Linux support for ARC Shahab Vahedi
2020-08-17 8:07 ` [PATCH v6 0/4] arc: Add GNU/Linux support Shahab Vahedi
2020-08-17 14:12 ` Eli Zaretskii
2020-08-25 15:47 ` [PUSHED " Shahab Vahedi
2020-08-25 15:47 ` [PUSHED 1/4] arc: Add ARCv2 XML target along with refactoring Shahab Vahedi
2020-08-25 16:00 ` Eli Zaretskii
2020-08-25 15:47 ` [PUSHED 2/4] arc: Add inclusion of "gdbarch.h" in "arc-tdep.h" Shahab Vahedi
2020-08-25 15:47 ` [PUSHED 3/4] arc: Add hardware loop detection Shahab Vahedi
2020-08-25 15:58 ` Eli Zaretskii
2020-08-25 15:47 ` [PUSHED 4/4] arc: Add GNU/Linux support for ARC Shahab Vahedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837dud9nbh.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=anton.kolesov@synopsys.com \
--cc=fbedard@synopsys.com \
--cc=gdb-patches@sourceware.org \
--cc=shahab.vahedi@gmail.com \
--cc=shahab@synopsys.com \
--cc=simark@simark.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).