[PATCH] gdb: Disable source-highlight static libstdc++ check

[PATCH] gdb: Disable source-highlight static libstdc++ check

[Stephanos Ioannidis]

This patch removes the libstdc++ static linking prevention check when
the libsource-highlight (aka. GNU Source Highlight) library is used.

The commit d806ea2d0ef362fcddd2c1659f537b68aa114203 introduced this
requirement in order to prevent exception handling issues when mixing
dynamic C++ libraries and static libstdc++; however, this restriction
does not apply when all linked C++ libraries are in the static form.

Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
---
 gdb/configure    | 6 ------
 gdb/configure.ac | 8 --------
 2 files changed, 14 deletions(-)

diff --git a/gdb/configure b/gdb/configure
index b572d414ca..f659a4772b 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -11344,12 +11344,6 @@ $as_echo "no - pkg-config not found" >&6; }
       as_fn_error $? "pkg-config was not found in your system" "$LINENO" 5
     fi
   else
-    case "$LDFLAGS" in
-      *static-libstdc*)
-        as_fn_error $? "source highlight is incompatible with -static-libstdc++; either use --disable-source-highlight or --without-static-standard-libraries" "$LINENO" 5
-        ;;
-    esac
-
     if ${pkg_config_prog_path} --exists source-highlight; then
       SRCHIGH_CFLAGS=`${pkg_config_prog_path} --cflags source-highlight`
       SRCHIGH_LIBS=`${pkg_config_prog_path} --libs source-highlight`
diff --git a/gdb/configure.ac b/gdb/configure.ac
index ca0da7980c..6d5526a516 100644
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -1179,14 +1179,6 @@ if test "${enable_source_highlight}" != "no"; then
       AC_MSG_ERROR([pkg-config was not found in your system])
     fi
   else
-    case "$LDFLAGS" in
-      *static-libstdc*)
-        AC_MSG_ERROR([source highlight is incompatible with -static-libstdc++; dnl
-either use --disable-source-highlight or dnl
---without-static-standard-libraries])
-        ;;
-    esac
-
     if ${pkg_config_prog_path} --exists source-highlight; then
       SRCHIGH_CFLAGS=`${pkg_config_prog_path} --cflags source-highlight`
       SRCHIGH_LIBS=`${pkg_config_prog_path} --libs source-highlight`
-- 
2.26.2

Re: [PATCH] gdb: Disable source-highlight static libstdc++ check

[Eli Zaretskii]

> From: Stephanos Ioannidis <root@stephanos.io>
> Date: Tue,  2 Jun 2020 12:52:06 +0900
> Cc: Stephanos Ioannidis <root@stephanos.io>
> 
> This patch removes the libstdc++ static linking prevention check when
> the libsource-highlight (aka. GNU Source Highlight) library is used.
> 
> The commit d806ea2d0ef362fcddd2c1659f537b68aa114203 introduced this
> requirement in order to prevent exception handling issues when mixing
> dynamic C++ libraries and static libstdc++; however, this restriction
> does not apply when all linked C++ libraries are in the static form.

This LGTM, and is exactly what I did last time I built GDB with
source-highlight.

Thanks.

Re: [PATCH] gdb: Disable source-highlight static libstdc++ check

[Tom Tromey]

>>>>> "Stephanos" == Stephanos Ioannidis <root@stephanos.io> writes:

Hi.  Thanks for the patch.

Stephanos> This patch removes the libstdc++ static linking prevention check when
Stephanos> the libsource-highlight (aka. GNU Source Highlight) library is used.

Patches have to come with a ChangeLog entry.
See the contribution checklist:

https://sourceware.org/gdb/wiki/ContributionChecklist

Stephanos> The commit d806ea2d0ef362fcddd2c1659f537b68aa114203 introduced this
Stephanos> requirement in order to prevent exception handling issues when mixing
Stephanos> dynamic C++ libraries and static libstdc++; however, this restriction
Stephanos> does not apply when all linked C++ libraries are in the static form.

It seems like this would just reintroduce the build problem that this
addition was intended to fix.  Maybe some option to circumvent this
check would be better.

Tom