From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84294 invoked by alias); 23 May 2018 17:44:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84283 invoked by uid 89); 23 May 2018 17:44:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:RSA_AES X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 May 2018 17:44:44 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fLXoV-0001IN-6F for gdb-patches@sourceware.org; Wed, 23 May 2018 13:44:43 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46021) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLXoL-00019v-C0; Wed, 23 May 2018 13:44:29 -0400 Received: from [176.228.60.248] (port=2677 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fLXoK-00055T-Kd; Wed, 23 May 2018 13:44:29 -0400 Date: Wed, 23 May 2018 19:21:00 -0000 Message-Id: <837enuclmj.fsf@gnu.org> From: Eli Zaretskii To: Gary Benson CC: gdb-patches@sourceware.org, simon.marchi@ericsson.com, palves@redhat.com In-reply-to: <1527096776-29187-1-git-send-email-gbenson@redhat.com> (message from Gary Benson on Wed, 23 May 2018 18:32:56 +0100) Subject: Re: [PATCH v2] linux: Add maintenance commands to test libthread_db Reply-to: Eli Zaretskii References: <1511361761-1333-1-git-send-email-gbenson@redhat.com> <1527096776-29187-1-git-send-email-gbenson@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00630.txt.bz2 > From: Gary Benson > Cc: Simon Marchi , Pedro Alves > Date: Wed, 23 May 2018 18:32:56 +0100 > > The test itself is a basic integrity check exercising all libthread_db > functions used by GDB on GNU/Linux systems. By extension this also > exercises the proc_service functions provided by GDB that libthread_db > uses. This is useful for NPTL developers and libthread_db developers. > It could also prove useful investigating bugs reported against GDB > where the thread debugging library or GDB's proc_service layer is > suspect. I think some of this text should be in the manual, otherwise the description of the command is not very useful. > diff --git a/gdb/NEWS b/gdb/NEWS > index cef5580..2e6cb74 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -27,6 +27,16 @@ set|show record btrace cpu > Controls the processor to be used for enabling errata workarounds for > branch trace decode. > > +maint check libthread-db > + Run integrity checks on the current inferior's thread debugging > + library > + > +maint set check-libthread-db (on|off) > +maint show check-libthread-db > + Control whether to run integrity checks on inferior specific thread > + debugging libraries as they are loaded. The default is not to > + perform such checks. > + > * Python API This part is OK. > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index 28f083f..6faaabe 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -35533,6 +35533,11 @@ modify XML target descriptions. > Check that the target descriptions dynamically created by @value{GDBN} > equal the descriptions created from XML files found in @var{dir}. > > +@kindex maint check libthread-db > +@item maint check libthread-db > +Run integrity checks on the current inferior's thread debugging > +library. > + > @kindex maint print dummy-frames > @item maint print dummy-frames > Prints the contents of @value{GDBN}'s internal dummy-frame stack. > @@ -35840,6 +35845,14 @@ number of blocks in the blockvector > @end enumerate > @end table > > +@kindex maint set check-libthread-db > +@kindex maint show check-libthread-db > +@item maint set check-libthread-db [on|off] > +@itemx maint show check-libthread-db > +Control whether @value{GDBN} should run integrity checks on inferior > +specific thread debugging libraries as they are loaded. The default > +is not to perform such checks. > + This is also OK, modulo the request to expand the description. Thanks.