From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 271A53858C2F for ; Tue, 12 Dec 2023 18:39:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 271A53858C2F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 271A53858C2F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702406356; cv=none; b=fIAP8jIIS5n2Ay3AWxb8jIHmZBRhQekAXuvlXk+D9X2RQlz/9aB1X1+baIPlzDnj7u0QOF3B1c5nADUgj1Wy+2ofLzNrp7NC0O+UgL5FNny6hUY54XzUaJwIVnHhbT6CL7zF/pFr35ubf8i8keScj7/mVEA3Wemk6NaY+2ZBrKs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702406356; c=relaxed/simple; bh=iMD2637cXSZrpB6OI3Aeffj5v1F/I+4WB6GJIsUPtK8=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=F+dVdJZIZGEMV1wZY2MoY1GDFyLRkSAmpIlM6Wy4HEjoxCbFXT906Vxo7twvP0mhPz6QxTyFPBKG/pdCdveqgsw6fIyh+aerEr/+tsgE0Mw0PlmyF0i0F0z4ULpXtbsh0LMh0tmJyXwd8s3sD8Si5ZT17Zusi46uKSJVOo/hz0U= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rD7f0-0001n2-Op; Tue, 12 Dec 2023 13:39:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=iGYWiwBIfam3ai2L0pYpL6tg++3YctJx3JULf8Ln9bg=; b=DoxACpRddoLs OYqr3Y8AqUNIWoYmSacisP4rLRPoxqwYbMW+xYrA2M9jWRTvIiQDdqjUnKJLOTcu485nni7Wht4M9 FWmkBPGK169NfVMfjRvLQEtkdvcy5FU9rY9jB7c197uq5acLeqGasDIRK2K8ikCubHFqKuVLEqORv WK5UhAG9J2jeLB8xzSIyN2SRmWh540OuQFPB2v90cvZ5WN3Vx8JmdtOFOvauxyVt+yuru65ymTn7C 1VPSNl1IlnK1tkiw468chA3tPdMuMhqQymmKvwaZoG+T6BcK+wo+7NjCPULOyk1sPcah3H9lAsjGl DNub0SfjH4pOPx/go5OxAQ==; Date: Tue, 12 Dec 2023 20:39:08 +0200 Message-Id: <838r5ztgdv.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey Cc: gdb-patches@sourceware.org In-Reply-To: <20231212-dap-no-test-exceptions-v1-2-af0e33f10093@adacore.com> (message from Tom Tromey on Tue, 12 Dec 2023 10:44:43 -0700) Subject: Re: [PATCH 2/4] Add DAP log level parameter References: <20231212-dap-no-test-exceptions-v1-0-af0e33f10093@adacore.com> <20231212-dap-no-test-exceptions-v1-2-af0e33f10093@adacore.com> X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Tom Tromey > Date: Tue, 12 Dec 2023 10:44:43 -0700 > > This adds a new parameter to control the DAP logging level. By > default, "expected" exceptions are not logged, but the parameter lets > the user change this when more logging is desired. > > This also changes a couple of spots to avoid logging the stack trace > for a DAPException. > > This patch also documents the existing DAP logging parameter. I > forgot to document this before. > --- > gdb/NEWS | 5 +++++ > gdb/doc/gdb.texinfo | 18 ++++++++++++++++++ > gdb/python/lib/gdb/dap/breakpoint.py | 6 ++++-- > gdb/python/lib/gdb/dap/server.py | 10 ++++++++++ > gdb/python/lib/gdb/dap/startup.py | 29 +++++++++++++++++++++++++---- > 5 files changed, 62 insertions(+), 6 deletions(-) Thanks, the documentation parts are okay, with one comment: > +@table @code > +@item set debug dap-log-file @r{[}@var{filename}@r{]} > +Enable DAP logging. Logs are written to the specified file. If no > +file is given, logging is stopped. I suggest to use "@var{filename}" instead of "file" here, on both occasions. Reviewed-By: Eli Zaretskii