From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 4C37F3858D28 for ; Wed, 21 Jun 2023 11:12:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4C37F3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBvli-0002b0-Ov; Wed, 21 Jun 2023 07:12:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ltRIWdfwFhOrFuliwgYeglEgc/JktIAlgDyVh2Sk7Qc=; b=r9iqqET9XHca c18kWW+/S6pMjUzPClPWXsxP2n21+0GO3Mne5iuhptuPdGR5Cvma6jLJWpai7AXJj6KD9/TE80BAT l1gwFq/NsFqeQi1UpLNgjSnqZAyNHaXfsc2CJT4HHAawkVtoruvENK7/nec0Oshr6vWxDKDI1Wj04 YxDe/x8tg83C0QBgFsPSwfuKCPSJPid1NVpBw6Vckq9Bot5urVAPK4zAysYVaMplYZ4zJFTIdjakc aY59qbX5y26OLeaDaKr65ZxTInz1/fQDw6lMxR2vLW/W5Ruj8fLRscW42L9RcLq93gcFiBTzrfCq6 TWtSCVrYUKZZJnrrHdGk/w==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBvli-0006BV-8i; Wed, 21 Jun 2023 07:12:58 -0400 Date: Wed, 21 Jun 2023 14:13:07 +0300 Message-Id: <838rcd5arg.fsf@gnu.org> From: Eli Zaretskii To: Bruno Larsen Cc: gdb-patches@sourceware.org In-Reply-To: <20230621104545.2530552-5-blarsen@redhat.com> (message from Bruno Larsen on Wed, 21 Jun 2023 12:45:45 +0200) Subject: Re: [PATCH v3 4/4] gdb/doc: document '+' argument for 'list' command References: <20230621104545.2530552-1-blarsen@redhat.com> <20230621104545.2530552-5-blarsen@redhat.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Bruno Larsen > Cc: Bruno Larsen , > Eli Zaretskii > Date: Wed, 21 Jun 2023 12:45:45 +0200 > > The command 'list' has accepted the argument '+' for many years already, > but this option wasn't documented either in the texinfo docs or in the > help text for the command. This commit documents it. > > Reviewed-By: Eli Zaretskii > --- > gdb/cli/cli-cmds.c | 1 + > gdb/doc/gdb.texinfo | 4 ++++ > 2 files changed, 5 insertions(+) > > diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c > index a966142eaea..b7cbe673985 100644 > --- a/gdb/cli/cli-cmds.c > +++ b/gdb/cli/cli-cmds.c > @@ -2822,6 +2822,7 @@ and send its output to SHELL_COMMAND.")); > List specified function or line.\n\ > With no argument, lists ten more lines after or around previous listing.\n\ > \"list .\" lists ten lines arond where the inferior is stopped.\n\ > +\"list +\" lists the ten lines following a previous ten-line listing.\n\ > \"list -\" lists the ten lines before a previous ten-line listing.\n\ > One argument specifies a line, and ten lines are listed around that line.\n\ > Two arguments with comma between specify starting and ending lines to list.\n\ This part is OK. > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index e4e374d138c..f9c3c90e16a 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -9149,6 +9149,10 @@ Stack}), this prints lines centered around that line. If no > @code{list} command has been used and no solitary line was printed, > it prints the lines around the function @code{main}. > > +@item list + > +Same as using with no arguments, but errors out if the line is > +past the end of the file. But here it looks like some copy/pasta error?