From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id C8FEC3858D28 for ; Wed, 18 Jan 2023 17:35:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C8FEC3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pICL8-0001fl-D4; Wed, 18 Jan 2023 12:35:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/2NJKqSIuyNdpbDl8CZEFw5c86TcVIbxodKgt8La43M=; b=MEA+sEnNNGcv 6lfbt3viIWBRo6LYWf/YjBez2Can3UZZvQOKTFyz8/iWsBlBV0uI63pbSm9L/fwxlIgk6bYGkQjoS rgyzBtkoXQNilHBT5R640jqpoiwORYVXXA3KwGLPSJCXZQV6AY5aT5KCQUKpzqJ73NcMkXpBx1JIY N7kuBwYj1rF6jEd05T5V/I07Eqc3QVrQ6serhdTF79qI7GTRar3tNpaVAyWipWG//NRbLnlTq5hzM CbrA6s5i5t52XojVF+HxPgp/ufDIBAQQ+2UQZ/KEHyUosixwl1gRfwAVMM5+6vQ38KbETkUz7YEQW 5hgkKStFlFuCUFm4fN6nEA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pICL7-0003qt-Mw; Wed, 18 Jan 2023 12:35:10 -0500 Date: Wed, 18 Jan 2023 19:35:24 +0200 Message-Id: <838rhz21b7.fsf@gnu.org> From: Eli Zaretskii To: Andrew Burgess Cc: gdb-patches@sourceware.org In-Reply-To: (message from Andrew Burgess via Gdb-patches on Wed, 18 Jan 2023 16:18:09 +0000) Subject: Re: [PATCHv2 13/13] gdb: rename unwindonsignal to unwind-on-signal References: X-Spam-Status: No, score=1.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Cc: Andrew Burgess > Date: Wed, 18 Jan 2023 16:18:09 +0000 > From: Andrew Burgess via Gdb-patches > > We now have unwind-on-timeout and unwind-on-terminating-exception, and > then the odd one out unwindonsignal. > > I'm not a great fan of these squashed together command names, so in > this commit I propose renaming this to unwind-on-signal. > > Obviously I've added the hidden alias unwindonsignal so any existing > GDB scripts will keep working. > > There's one test that I've extended to test the alias works, but in > most of the other test scripts I've changed over to use the new name. > > The docs are updated to reference the new name. > --- > gdb/NEWS | 11 ++++++ > gdb/doc/gdb.texinfo | 16 ++++++--- > gdb/infcall.c | 21 ++++++----- > gdb/testsuite/gdb.base/callfuncs.exp | 4 +-- > gdb/testsuite/gdb.base/infcall-failure.exp | 4 +-- > gdb/testsuite/gdb.base/unwindonsignal.exp | 36 +++++++++++++------ > gdb/testsuite/gdb.compile/compile-cplus.exp | 2 +- > gdb/testsuite/gdb.compile/compile.exp | 2 +- > gdb/testsuite/gdb.cp/gdb2495.exp | 16 ++++----- > gdb/testsuite/gdb.fortran/function-calls.exp | 2 +- > gdb/testsuite/gdb.mi/mi-syn-frame.exp | 2 +- > .../infcall-from-bp-cond-simple.exp | 2 +- > .../gdb.threads/thread-unwindonsignal.exp | 8 ++--- > 13 files changed, 83 insertions(+), 43 deletions(-) These are mechanical renames, right? I don't think they need a review and approval. Thanks.