From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id 59F993858C83
 for <gdb-patches@sourceware.org>; Tue, 19 Apr 2022 16:16:33 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 59F993858C83
Received: from fencepost.gnu.org ([2001:470:142:3::e]:43408)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1ngqWm-0004tN-JA; Tue, 19 Apr 2022 12:16:32 -0400
Received: from [87.69.77.57] (port=3888 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1ngqWl-0007Wp-DZ; Tue, 19 Apr 2022 12:16:32 -0400
Date: Tue, 19 Apr 2022 19:16:22 +0300
Message-Id: <838rs1ujzd.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org, brobecker@adacore.com, pedro@palves.net
In-Reply-To: <874k2prr1c.fsf@redhat.com> (message from Andrew Burgess on Tue, 
 19 Apr 2022 17:12:15 +0100)
Subject: Re: GDB 12.0.90 available for testing
References: <87pmm096dc.fsf@redhat.com> <83zgl44w1m.fsf@gnu.org>
 <1379565857.1750775.1648990951974@mail.yahoo.com>
 <YkmpIf5RkPVOCj+8@adacore.com>
 <1113857996.1779276.1648999598328@mail.yahoo.com> <83czhyfa8i.fsf@gnu.org>
 <83wng1b161.fsf@gnu.org> <Yk8nZ47OXOEa3K0I@adacore.com>
 <YlMqzEhQIc+YKc4Y@adacore.com> <83tuaz6e3x.fsf@gnu.org>
 <YlxOKz+FILo23F1g@adacore.com> <874k2prr1c.fsf@redhat.com>
X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Apr 2022 16:16:34 -0000

> From: Andrew Burgess <aburgess@redhat.com>
> Cc: Eli Zaretskii <eliz@gnu.org>, Joel Brobecker <brobecker@adacore.com>, pedro@palves.net
> Date: Tue, 19 Apr 2022 17:12:15 +0100
> 
> Sorry for the slow reply, I've been off for the last week, so I'm only
> just catching up with my GDB emails.
> 
> How does the patch below look?  This moves the setbuf call into a new
> function, and includes the comment from gdb_readline_no_editing_callback.

Thanks.  However, the patch that I tested only used the ISATTY test in
ui::ui, not in read_command.  Not sure if that matters.