From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id E33943851C2A for ; Sun, 28 Jun 2020 16:40:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E33943851C2A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eliz@gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]:44810) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpaMB-00017U-Gy; Sun, 28 Jun 2020 12:40:39 -0400 Received: from [176.228.60.248] (port=2467 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jpaMA-0007hv-AU; Sun, 28 Jun 2020 12:40:38 -0400 Date: Sun, 28 Jun 2020 19:40:28 +0300 Message-Id: <838sg72lfn.fsf@gnu.org> From: Eli Zaretskii To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: gdb-patches@sourceware.org In-Reply-To: <20200628142540.11320-1-ludo@gnu.org> (message from Ludovic =?utf-8?Q?Court=C3=A8s?= on Sun, 28 Jun 2020 16:25:39 +0200) Subject: Re: [PATCH v4 1/2] guile: Add support for Guile 2.2. References: <87v9jbi855.fsf@gnu.org> <20200628142540.11320-1-ludo@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Jun 2020 16:40:45 -0000 > From: Ludovic Courtès > Date: Sun, 28 Jun 2020 16:25:39 +0200 > Cc: Ludovic Courtès > > This primarily updates code that uses the I/O port API of Guile. > > gdb/ChangeLog > 2020-06-28 Ludovic Courtès > Doug Evans > > PR gdb/21104 > * guile/scm-ports.c (USING_GUILE_BEFORE_2_2): New macro. > (ioscm_memory_port)[read_buf_size, write_buf_size]: Wrap in #if > USING_GUILE_BEFORE_2_2. > (stdio_port_desc, memory_port_desc) [!USING_GUILE_BEFORE_2_2]: > Change type to 'scm_t_port_type *'. > (natural_buffer_size) [!USING_GUILE_BEFORE_2_2]: New variable. > (ioscm_open_port) [USING_GUILE_BEFORE_2_2]: Add 'stream' > parameter and honor it. Update callers. > (ioscm_open_port) [!USING_GUILE_BEFORE_2_2]: New function. > (ioscm_read_from_port, ioscm_write) [!USING_GUILE_BEFORE_2_2]: New > functions. > (ioscm_fill_input, ioscm_input_waiting, ioscm_flush): Wrap in #if > USING_GUILE_BEFORE_2_2. > (ioscm_init_gdb_stdio_port) [!USING_GUILE_BEFORE_2_2]: Use > 'ioscm_read_from_port'. Call 'scm_set_port_read_wait_fd'. > (ioscm_init_stdio_buffers) [!USING_GUILE_BEFORE_2_2]: New function. > (gdbscm_stdio_port_p) [!USING_GUILE_BEFORE_2_2]: Use 'SCM_PORTP' > and 'SCM_PORT_TYPE'. > (gdbscm_memory_port_end_input, gdbscm_memory_port_seek) > (ioscm_reinit_memory_port): Wrap in #if USING_GUILE_BEFORE_2_2. > (gdbscm_memory_port_read, gdbscm_memory_port_write) > (gdbscm_memory_port_seek, gdbscm_memory_port_close) > [!USING_GUILE_BEFORE_2_2]: New functions. > (gdbscm_memory_port_print): Remove use of 'SCM_PTOB_NAME'. > (ioscm_init_memory_port_type) [!USING_GUILE_BEFORE_2_2]: Use > 'gdbscm_memory_port_read'. > Wrap 'scm_set_port_end_input', 'scm_set_port_flush', and > 'scm_set_port_free' calls in #if USING_GUILE_BEFORE_2_2. > (gdbscm_get_natural_buffer_sizes) [!USING_GUILE_BEFORE_2_2]: New > function. > (ioscm_init_memory_port): Remove. > (ioscm_init_memory_port_stream): New function > (ioscm_init_memory_port_buffers) [USING_GUILE_BEFORE_2_2]: New > function. > (gdbscm_memory_port_read_buffer_size) [!USING_GUILE_BEFORE_2_2]: > Return scm_from_uint (0). > (gdbscm_set_memory_port_read_buffer_size_x) > [!USING_GUILE_BEFORE_2_2]: Call 'scm_setvbuf'. > (gdbscm_memory_port_write_buffer_size) [!USING_GUILE_BEFORE_2_2]: > Return scm_from_uint (0). > (gdbscm_set_memory_port_write_buffer_size_x) > [!USING_GUILE_BEFORE_2_2]: Call 'scm_setvbuf'. > * configure.ac (try_guile_versions): Add "guile-2.2". > * configure: Regenerate. > * NEWS: Add entry. > > gdb/testsuite/ChangeLog > 2020-06-28 Ludovic Courtès > > * gdb.guile/scm-error.exp ("source $remote_guile_file_1"): Relax > error regexp to match on Guile 2.2. > > gdb/doc/ChangeLog > 2020-06-28 Ludovic Courtès > > * guile.texi (Memory Ports in Guile): Mark > 'memory-port-read-buffer-size', > 'set-memory-port-read-buffer-size!', > 'memory-port-write-buffer-size', > 'set-memory-port-read-buffer-size!' as deprecated. > * doc/guile.texi (Guile Introduction): Clarify which Guile > versions are supported. The documentation parts are okay, thanks. (If you agree with my last comment about reference to the Guile 2.2 manual, I'd appreciate a fix; otherwise we can handle that later.)