From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9182 invoked by alias); 1 Mar 2019 13:56:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9163 invoked by uid 89); 1 Mar 2019 13:56:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=HTo:U*palves, Hx-languages-length:1291 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 01 Mar 2019 13:56:52 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48382) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzied-0007oy-P3; Fri, 01 Mar 2019 08:56:48 -0500 Received: from [176.228.60.248] (port=3391 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gzieX-0004qx-EU; Fri, 01 Mar 2019 08:56:44 -0500 Date: Fri, 01 Mar 2019 13:56:00 -0000 Message-Id: <838sxyitq5.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves CC: tom@tromey.com, gdb-patches@sourceware.org In-reply-to: <7975162f-0b68-4826-6d6c-839d7953937d@redhat.com> (message from Pedro Alves on Fri, 1 Mar 2019 13:10:35 +0000) Subject: Re: [PATCH 00/16] Add styling to the gdb CLI and TUI References: <20181128001435.12703-1-tom@tromey.com> <83k1kxfzwo.fsf@gnu.org> <8736rja4i8.fsf@tromey.com> <83r2f3caje.fsf@gnu.org> <87o9a61qvz.fsf@tromey.com> <7975162f-0b68-4826-6d6c-839d7953937d@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00006.txt.bz2 > Cc: gdb-patches@sourceware.org > From: Pedro Alves > Date: Fri, 1 Mar 2019 13:10:35 +0000 > > The Windows console in Windows 10 Anniversary Update supports ANSI escape sequences: > > [1] https://docs.microsoft.com/en-us/windows/console/console-virtual-terminal-sequences > [2] https://blogs.msdn.microsoft.com/commandline/2017/04/11/windows-10-creators-update-whats-new-in-bashwsl-windows-console/ Yes, I know. I guess GDB will have to use that, at least at some point, or maybe as an option even today. Thanks for the pointers, regardless. > Basically, GDB needs to call SetConsoleMode with > ENABLE_VIRTUAL_TERMINAL_PROCESSING at early startup to enable the feature. > There's an example at the bottom of page [1] above. > > I have no idea whether that interacts badly with readline or curses, but > it seems like the ideal solution going forward. We don't want to require Windows 10 for the styling support, do we? Older versions of Windows still have quite a few years before they are unsupported even by Microsoft, let alone GDB. Or are you saying that you will be unwilling to accept patches that enable styling on all versions of Windows (by converting SGR sequences to corresponding Windows API calls)?