public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: gdb-patches@sourceware.org
Cc: sergiodj@redhat.com
Subject: Re: "make TAGS" broken in 7.8.90
Date: Thu, 22 Jan 2015 18:11:00 -0000	[thread overview]
Message-ID: <838uguvg9c.fsf@gnu.org> (raw)
In-Reply-To: <83twzlwe3p.fsf@gnu.org>

> Date: Tue, 20 Jan 2015 19:34:18 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: Sergio Durigan Junior <sergiodj@redhat.com>
> 
> "make TAGS" is broken.  Again.  (Sergio, would it make sense to add
> "make TAGS" to the list of commands run by the buildbot after a build?
> This breaks too often, IMO.)
> 
>      Doing TAGS in gdb
>      make[2]: Entering directory `/d/usr/eli/utils/gdb-7.8.90/gdb'
>      make[2]: *** No rule to make target `ada-varobj.h', needed by `TAGS'.
>      make[2]: Target `TAGS' not remade because of errors.
>      ./x86-dregs.c: No such file or directory
>      ./irix5-nat.c: No such file or directory
> 
> ada-varobj.h and irix5-nat.c should simply be removed from the
> respective lists.

I've just pushed the below as obvious.

> But I'm not sure how to fix the x86-dregs.c issue.
> The problem here is that x86-dregs.o is in gdb/, but the source is in
> gdb/nat/, so the simplistic editing:
> 
> 	done) | sed 's/\.o$$/\.c/'` \
> 
> doesn't work.  Thoughts?
> 
> One other annoyance with "make TAGS" is that libdecnumber doesn't
> support that target, so you must invoke the command from gdb/, or use
> "make -k", otherwise it bails out.  Any reason not to support TAGS in
> libdecnumber?

Still didn't fix these.  Any ideas for an elegant solution?

commit 82a864f96aff83edb0c8bb21ead5c28cd10363fe
Author: Eli Zaretskii <eliz@gnu.org>
Date:   Thu Jan 22 20:05:59 2015 +0200

    Partial fix for "make TAGS".
    
    gdb/
    2015-01-22  Eli Zaretskii  <eliz@gnu.org>
    
    	* Makefile.in (HFILES_NO_SRCDIR): Remove ada-varobj.h.
    	(ALLDEPFILES): Remove irix5-nat.c.  These two are part of the
    	reason that "make TAGS" is broken.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index fee6903..06be4ed 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2015-01-22  Eli Zaretskii  <eliz@gnu.org>
+
+	* Makefile.in (HFILES_NO_SRCDIR): Remove ada-varobj.h.
+	(ALLDEPFILES): Remove irix5-nat.c.  These two are part of the
+	reason that "make TAGS" is broken.
+
 2015-01-22  Chen Gang  <gang.chen.5i5j@gmail.com>
 
 	* hppa-tdep.c (inst_saves_gr): Fix logical working flow issues
diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index 6b270eb..8addef4 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -890,7 +890,7 @@ proc-utils.h aarch64-tdep.h arm-tdep.h ax-gdb.h ppcfbsd-tdep.h \
 ppcnbsd-tdep.h cli-out.h gdb_expat.h breakpoint.h infcall.h obsd-tdep.h \
 exec.h m32r-tdep.h osabi.h gdbcore.h solib-som.h amd64bsd-nat.h \
 i386bsd-nat.h xml-support.h xml-tdesc.h alphabsd-tdep.h gdb_obstack.h \
-ia64-tdep.h ada-lang.h ada-varobj.h varobj.h varobj-iter.h frv-tdep.h \
+ia64-tdep.h ada-lang.h varobj.h varobj-iter.h frv-tdep.h \
 nto-tdep.h serial.h \
 c-lang.h d-lang.h go-lang.h frame.h event-loop.h block.h cli/cli-setshow.h \
 cli/cli-decode.h cli/cli-cmds.h cli/cli-utils.h \
@@ -1666,7 +1666,6 @@ ALLDEPFILES = \
 	ia64-hpux-nat.c ia64-hpux-tdep.c \
 	ia64-linux-nat.c ia64-linux-tdep.c ia64-tdep.c ia64-vms-tdep.c \
 	inf-ptrace.c inf-ttrace.c \
-	irix5-nat.c \
 	ia64-libunwind-tdep.c \
 	linux-fork.c \
 	linux-tdep.c \

      parent reply	other threads:[~2015-01-22 18:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-20 17:36 Eli Zaretskii
2015-01-20 17:50 ` Sergio Durigan Junior
2015-01-20 18:26   ` Eli Zaretskii
2015-01-20 22:48     ` Sergio Durigan Junior
2015-01-22 18:11 ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838uguvg9c.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=sergiodj@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).