From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-118726-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18070 invoked by alias); 5 Jan 2015 20:50:08 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 18060 invoked by uid 89); 5 Jan 2015 20:50:08 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout24.012.net.il
Received: from mtaout24.012.net.il (HELO mtaout24.012.net.il) (80.179.55.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 05 Jan 2015 20:50:06 +0000
Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NHQ00E0011AFI00@mtaout24.012.net.il> for gdb-patches@sourceware.org; Mon, 05 Jan 2015 22:42:05 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NHQ009FA1I5CG60@mtaout24.012.net.il>; Mon, 05 Jan 2015 22:42:05 +0200 (IST)
Date: Mon, 05 Jan 2015 20:50:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] "info source" now includes producer string
In-reply-to: <yjt2h9w52c4v.fsf@ruffy.mtv.corp.google.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <838uhh7y0t.fsf@gnu.org>
References: <yjt2h9w52c4v.fsf@ruffy.mtv.corp.google.com>
X-IsSubscribed: yes
X-SW-Source: 2015-01/txt/msg00060.txt.bz2

> From: Doug Evans <dje@google.com>
> Date: Mon, 05 Jan 2015 12:41:52 -0800
> 
> bash$ g++ -g -Og hello.cc -o hello
> bash$ gdb hello
> (gdb) start
> (gdb) info source
> Current source file is hello.cc
> Compilation directory is /home/dje
> Located in /home/dje/hello.cc
> Contains 8 lines.
> Source language is c++.
> Producer is GNU C++ 4.8.2 -mtune=generic -march=x86-64 -g -Og -fstack-protector.
> Compiled with DWARF 2 debugging format.
> Does not include preprocessor macro info.

Thanks.

> 	* NEWS: "info source" command now display producer string if present.
                                          ^^^^^^^
"displays"

> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -113,6 +113,9 @@ VAX running Ultrix 			vax-*-ultrix*
>    and "assf"), have been removed.  Use the "sharedlibrary" command, or
>    its alias "share", instead.
>  
> +* The "info source" command now displays the producer string if it was
> +  present in the debug info.

I wonder whether we should replace "producer" with something less
abstract.  Would "compilation command line" be accurate enough?

> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -16279,6 +16279,8 @@ its length, in lines,
>  @item
>  which programming language it is written in,
>  @item
> +if the debug information provides it, the program that compiled the file,

Not just the program, but also its command line, right?

Okay with those fixed.