From: "Paweł Wódkowski" <pwodkowski@pl.sii.eu>
To: Richard Bunt <Richard.Bunt@arm.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: nd <nd@arm.com>
Subject: Re: [PATCH v2 3/7] Fortran: Accessing fields of inherited types via fully qualified name.
Date: Wed, 06 Feb 2019 12:39:00 -0000 [thread overview]
Message-ID: <83a3b782d70b4e85b0a0386c07b3cf88@pl.sii.eu> (raw)
In-Reply-To: <9c1d974d-d5f3-93f7-12b0-0c95ac264cde@arm.com>
Mail didn't dropped.
During rebase to latest master I spotted that last patch about scope
operator stopped working. I can't figure this out yet, but setting
breakpoint using scope isn't working any more despite that gdb see
proper scope when I dump the symbols.
Sorry but this will take some more time for V3 version as I want to be
1000% sure this is working.
On 30.01.2019 12:10, Richard Bunt wrote:
> Mail tends to drop off the top of the list pretty quickly, so please
> keep pinging to help move the work along:
>
>> The generally accepted ping frequency is 2 weeks after first submission,
>> and every week thereafter.
> https://sourceware.org/gdb/wiki/ContributionChecklist (13)
>
> Many thanks,
>
> Rich.
>
> On 1/18/19 8:32 AM, Paweł Wódkowski wrote:
>> On 2019-01-16 12:11, Richard Bunt wrote:
>>> I have no further comments on v2 and look forward to v3.
>>>
>>> Many thanks,
>> Great, I tough that this was forgotten ;)
>>
>> If you don't mind I will decouple this feature from unrelated patches
>> in this series.
>>
>> I will send v3 shortly.
>>
>> Pawel
>>
>>> Rich.
>>>
>>> On 12/9/18 8:40 PM, Paweł Wódkowski wrote:
>>>> On 06.12.2018 16:02, Richard Bunt wrote:
>>>>> Hi Paweł,
>>>>>
>>>>> I was testing with gfortran 7.3.0 and ifort 18.2. On the latter I observe
>>>>> 2 kfails relating to the missing extends in the ptype output. However, this
>>>>> is because I do not have patch 4 applied. I will take a closer look at this
>>>>> patch with ifort 18.2 since I can analyze the implementation in action.
>>>>>
>>>> Ok, will wait (perhaps Wednesday) with v3. Pls, let know if there is
>>>> something more to change.
>>>>
>>>> btw, I have ifort 19.0.1.144 20181018
>>>>
>>>>
>>>>> On 12/4/18 9:05 PM, Paweł Wódkowski wrote:
>>>>>
>>>>>>>> +gdb_test "whatis wp_vla" "type = <not allocated>"
>>>>> A small nit while I'm here:
>>>>> GDB tests needs to be uniquely identifiable, see https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Make_sure_test_messages_are_unique
>>>>>
>>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: continue to breakpoint: ! After value assignment
>>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: continue to breakpoint: ! Before vla allocation
>>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: ptype wp%point%coo
>>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: ptype wp_vla(1)%point%coo
>>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp
>>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp%point
>>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp%point%coo
>>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp_vla(1)
>>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp_vla(1)%point
>>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp_vla(1)%point%coo
>>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: whatis wp
>>>>> 2 (gdb) PASS: gdb.fortran/oop-extend-type.exp: whatis wp_vla
>>>>>
>>>>>
>>>> Thx for the link. I will fix this.
>>>>
>>>> Pawel
>>>>
>>>>> Many thanks,
>>>>>
>>>>> Rich.
>>>>>
next prev parent reply other threads:[~2019-02-06 12:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 21:40 [PATCH v2 1/7] DWARF: Don't add nameless modules to partial symbol table Pawel Wodkowski
2018-11-19 21:40 ` [PATCH v2 3/7] Fortran: Accessing fields of inherited types via fully qualified name Pawel Wodkowski
2018-12-03 13:44 ` Richard Bunt
2018-12-04 21:05 ` Paweł Wódkowski
2018-12-06 15:03 ` Richard Bunt
2018-12-09 20:41 ` Paweł Wódkowski
2019-01-16 11:11 ` Richard Bunt
2019-01-18 8:33 ` Paweł Wódkowski
2019-01-30 11:10 ` Richard Bunt
2019-02-06 12:39 ` Paweł Wódkowski [this message]
2018-11-19 21:40 ` [PATCH v2 5/7] Fortran: Enable setting breakpoint on nested functions Pawel Wodkowski
2018-11-28 10:32 ` Richard Bunt
2018-12-02 22:16 ` Paweł Wódkowski
2018-11-19 21:40 ` [PATCH v2 6/7] Fortran: Nested functions, add scope parameter Pawel Wodkowski
2018-11-19 21:40 ` [PATCH v2 4/7] Fortran: Ptype, print type extension Pawel Wodkowski
2019-02-01 13:06 ` Andrew Burgess
2018-11-19 21:40 ` [PATCH v2 2/7] Dwarf: Fortran, support DW_TAG_entry_point Pawel Wodkowski
2018-11-27 22:09 ` Andrew Burgess
2018-12-02 21:32 ` Paweł Wódkowski
2018-11-19 21:40 ` [PATCH v2 7/7] Fortran: Document scope operator Pawel Wodkowski
2018-11-20 5:01 ` Eli Zaretskii
2018-11-22 16:14 ` Paweł Wódkowski
2018-11-23 10:31 ` Eli Zaretskii
2018-11-27 19:35 ` PING Re: [PATCH v2 1/7] DWARF: Don't add nameless modules to partial symbol table Pawel Wodkowski
2018-11-27 20:29 ` Simon Marchi
2018-11-27 21:42 ` Andrew Burgess
2018-12-02 21:01 ` Paweł Wódkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a3b782d70b4e85b0a0386c07b3cf88@pl.sii.eu \
--to=pwodkowski@pl.sii.eu \
--cc=Richard.Bunt@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).