From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2718 invoked by alias); 6 Feb 2019 12:39:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1188 invoked by uid 89); 6 Feb 2019 12:39:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*F:D*eu, wednesday, observe, inherited X-HELO: mail.pl.sii.eu Received: from mail.pl.sii.eu (HELO mail.pl.sii.eu) (91.227.21.9) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Feb 2019 12:39:18 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.pl.sii.eu (Postfix) with ESMTP id 4218611DE; Wed, 6 Feb 2019 13:39:16 +0100 (CET) Received: from mail.pl.sii.eu ([127.0.0.1]) by localhost (mail.pl.sii.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Sorq0s1MNOym; Wed, 6 Feb 2019 13:39:15 +0100 (CET) Received: from PRDSWEX16W2.SIIPOLSKA.PL (PRDSWEX16W2.SIIPOLSKA.PL [10.254.15.206]) by mail.pl.sii.eu (Postfix) with ESMTPS id 54D3410FE; Wed, 6 Feb 2019 13:39:15 +0100 (CET) Received: from PRDSWEX16W1.SIIPOLSKA.PL (10.254.15.205) by PRDSWEX16W2.SIIPOLSKA.PL (10.254.15.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1531.3; Wed, 6 Feb 2019 13:39:14 +0100 Received: from PRDSWEX16W1.SIIPOLSKA.PL ([fe80::3c9b:ace1:3462:3aae]) by PRDSWEX16W1.SIIPOLSKA.PL ([fe80::3c9b:ace1:3462:3aae%9]) with mapi id 15.01.1531.003; Wed, 6 Feb 2019 13:39:11 +0100 From: =?iso-8859-2?Q?Pawe=B3_W=F3dkowski?= To: Richard Bunt , "gdb-patches@sourceware.org" CC: nd Subject: Re: [PATCH v2 3/7] Fortran: Accessing fields of inherited types via fully qualified name. Date: Wed, 06 Feb 2019 12:39:00 -0000 Message-ID: <83a3b782d70b4e85b0a0386c07b3cf88@pl.sii.eu> References: <1542663530-140490-1-git-send-email-pwodkowski@pl.sii.eu> <1542663530-140490-3-git-send-email-pwodkowski@pl.sii.eu> <88ec6786-8834-7da2-207a-7392fd657e41@arm.com> <53cac622aea64147b2c1cd25feb16bdd@pl.sii.eu> <687ae24a-511f-1d32-025d-3c1e996a8e28@arm.com> <6a36a05571e94d01aafa6735e9f194ef@pl.sii.eu> <9c1d974d-d5f3-93f7-12b0-0c95ac264cde@arm.com> Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2019-02/txt/msg00037.txt.bz2 Mail didn't dropped. During rebase to latest master I spotted that last patch about scope operator stopped working. I can't figure this out yet, but setting breakpoint using scope isn't working any more despite that gdb see proper scope when I dump the symbols. Sorry but this will take some more time for V3 version as I want to be 1000% sure this is working. On 30.01.2019 12:10, Richard Bunt wrote: > Mail tends to drop off the top of the list pretty quickly, so please > keep pinging to help move the work along: > >> The generally accepted ping frequency is 2 weeks after first submission,= =20 >> and every week thereafter.=20 > https://sourceware.org/gdb/wiki/ContributionChecklist (13) > > Many thanks, > > Rich. > > On 1/18/19 8:32 AM, Pawe=B3 W=F3dkowski wrote: >> On 2019-01-16 12:11, Richard Bunt wrote: >>> I have no further comments on v2 and look forward to v3. >>> >>> Many thanks, >> Great, I tough that this was forgotten ;) >> >> If you don't mind I will decouple this feature from unrelated patches=20 >> in this series. >> >> I will send v3 shortly. >> >> Pawel >> >>> Rich. >>> >>> On 12/9/18 8:40 PM, Pawe=B3 W=F3dkowski wrote: >>>> On 06.12.2018 16:02, Richard Bunt wrote: >>>>> Hi Pawe=B3, >>>>> >>>>> I was testing with gfortran 7.3.0 and ifort 18.2. On the latter I obs= erve >>>>> 2 kfails relating to the missing extends in the ptype output. However= , this >>>>> is because I do not have patch 4 applied. I will take a closer look a= t this >>>>> patch with ifort 18.2 since I can analyze the implementation in actio= n. >>>>> >>>> Ok, will wait (perhaps Wednesday) with v3. Pls, let know if there is >>>> something more to change. >>>> >>>> btw, I have ifort 19.0.1.144 20181018 >>>> >>>> >>>>> On 12/4/18 9:05 PM, Pawe=B3 W=F3dkowski wrote: >>>>> >>>>>>>> +gdb_test "whatis wp_vla" "type =3D " >>>>> A small nit while I'm here: >>>>> GDB tests needs to be uniquely identifiable, see https://sourceware.o= rg/gdb/wiki/GDBTestcaseCookbook#Make_sure_test_messages_are_unique >>>>> >>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: continue to br= eakpoint: ! After value assignment >>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: continue to br= eakpoint: ! Before vla allocation >>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: ptype wp%point= %coo >>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: ptype wp_vla(1= )%point%coo >>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp >>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp%point >>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp%point%coo >>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp_vla(1) >>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp_vla(1)%po= int >>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp_vla(1)%po= int%coo >>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: whatis wp >>>>> 2 (gdb) PASS: gdb.fortran/oop-extend-type.exp: whatis wp_vla >>>>> >>>>> >>>> Thx for the link. I will fix this. >>>> >>>> Pawel >>>> >>>>> Many thanks, >>>>> >>>>> Rich. >>>>>