From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id CDCCC3858D32 for ; Tue, 14 Nov 2023 16:29:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CDCCC3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CDCCC3858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699979366; cv=none; b=qWrzPBsZTLrEIvuVTYR1SXdW3l79BmTCKDqu1jbVUUE4RGlnnl1mMu1Rs/2Lq8RDJYnp/vJBYgzOtVK/RnC2Nx7ayuCgFXly/5EC6CKVskyvNi5lC8nt1HTzCodjadhL4Wp0Iwcc9E3G7FPhFcqX7uCDyBTv7nV2IDXA9eaQn64= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699979366; c=relaxed/simple; bh=Fe9Q/xtzqqI41EAicXF6/1xVLcshQRAAGMAvgXBI+NY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=n8GdZgicHPpxsMjtadpurDLMXlKAxyFLo3pwq5TWgPsTd2OR9yT2uM6U9a4VRsYw9nvsBI+nBATbN1dP5r9lHYJuEERagGNxkSN8Usmp8lSctXBZMB/zsn8W2Oyg5iBgsHYm55DIy9xH+cnnikjfkhTIKe+7cF0WM9P8FEBj0Uc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699979363; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S4WaseLaSNxIdYuSV6qzJ/zKrdzOwIVASPBxywy9SJU=; b=V6Rjojo0Wf4wZBZH2jRbcDts/9xY/QI8yHFEuWIkWKLvhr5ik7IrVigGxCR2Yc6Tebg3cx /rUliVU5BOFmVVaOesyLij2wHVis1jTwuvVhDYw0454ECOFgrtg7IYgEdJekWw4ZCi06UO r0dq7tm83DdNeo9aH0XWG2J0jNoZKI0= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-649-4PQmEeDTN_OOMBT6IC4gJg-1; Tue, 14 Nov 2023 11:29:22 -0500 X-MC-Unique: 4PQmEeDTN_OOMBT6IC4gJg-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-9e644d94d85so472900266b.0 for ; Tue, 14 Nov 2023 08:29:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699979361; x=1700584161; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S4WaseLaSNxIdYuSV6qzJ/zKrdzOwIVASPBxywy9SJU=; b=hErt5NBc6xn0GMra7/EfV65ClIYiUICgJBlAc1Z7ms/l64ZwGwWLyc/0VHtysn5Uk7 SpA7xPZcmND0XnHS2OmhXt9AhLqmrSVG6dAErOT8DEmxCLw+YdoMMk4NvSA9DGjoWuyG 1QKuepLsim4NEfTX6NK5j2aw4ucWiJaVQATJkTqogMOjXgk3LhJBhbnGPhPXMtcQCOKz RJZinWvGcXWcrlQZMkM+Xzd35gyOheA2klT6CMrXQnE8I9+17+BcG6yW1OOsGMeammnf RjbupbAIRz3y5MY3Tqbxs8Jur+6KAQzPh0OGnRc8SE+R7MfKIgL1xDmimscUctkQFwQ9 y3iw== X-Gm-Message-State: AOJu0YxxAi2cNi4eoHndz7LbyvTMvLvOuhBl7eduAoV8XayacK51x6+9 ll/obgDVx+6kmTwLdtizqg//jFiJRZR30N1Q1p0HpLIAeT1emvCYhsIz4y67WeT6DYoJDiyCtf7 RcFVYJiHk06EqjRQYXI4U+0oC8/wEWQ== X-Received: by 2002:a17:907:e92:b0:9f1:a725:54a6 with SMTP id ho18-20020a1709070e9200b009f1a72554a6mr772141ejc.1.1699979360714; Tue, 14 Nov 2023 08:29:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IES8Si7crHV5H/QFjERomwZxLHeBk6rUbl6A39wOeK5SK7sIuqm2oAuWEnJkhoNPVWGHoEobQ== X-Received: by 2002:a17:907:e92:b0:9f1:a725:54a6 with SMTP id ho18-20020a1709070e9200b009f1a72554a6mr772128ejc.1.1699979360387; Tue, 14 Nov 2023 08:29:20 -0800 (PST) Received: from [192.168.0.129] (ip-94-112-227-180.bb.vodafone.cz. [94.112.227.180]) by smtp.gmail.com with ESMTPSA id gr23-20020a170906e2d700b009d3148fb9f6sm5753158ejb.22.2023.11.14.08.29.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Nov 2023 08:29:19 -0800 (PST) Message-ID: <83a46ebb-1635-9a0d-6cfd-00e2dac24584@redhat.com> Date: Tue, 14 Nov 2023 17:29:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [FYI/pushed v4 03/25] Step over clone syscall w/ breakpoint, TARGET_WAITKIND_THREAD_CLONED To: Pedro Alves , gdb-patches@sourceware.org Cc: Andrew Burgess References: <20231113150427.477431-1-pedro@palves.net> <20231113150427.477431-4-pedro@palves.net> <7c59b388-5ed0-ef55-a9f6-ea35066e15ba@redhat.com> <4ca9d82a-1989-43a1-bfc1-c1c4e6b40105@palves.net> From: Guinevere Larsen In-Reply-To: <4ca9d82a-1989-43a1-bfc1-c1c4e6b40105@palves.net> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 14/11/2023 14:26, Pedro Alves wrote: > Hi! > > On 2023-11-14 12:55, Guinevere Larsen wrote: >>> +gdb_test_multiple "catch syscall group:process" "catch process syscalls" { >>> +    -re "The feature \'catch syscall\' is not supported.*\r\n$gdb_prompt $" { >>> +    unsupported $gdb_test_name >>> +    return >>> +    } >>> +    -re ".*$gdb_prompt $" { >>> +    pass $gdb_test_name >>> +    } >>> +} >> In the clang buildbot we're getting this output: >> >> (gdb) catch syscall group:process >> warning: Can not parse XML syscalls information; XML support was disabled at compile time. >> Unknown syscall group 'process'. >> (gdb) PASS: gdb.threads/stepi-over-clone.exp: catch process syscalls >> >> This should be a failure, and should likely skip the next few tests. >> >> I don't know > Meh. I guess we should make it UNSUPPORTED and bail. But, really that is just > likely to make us not notice GDB wasn't built with XML support. There's really no > good reason for that nowadays. It's not like expat is a complicated dependency. That's fair. I still think that test should read FAIL if we get an XML parse fail, but maybe this isn't the place to leave early. I gave it some more thought, and I think the best place would be after the test builds the list of syscalls, if that list is empty there is no point in further testing, since no breakpoints will ever be set. I think a better the point to bail would be right before the main loop, since its unlikely we get an empty list at that point without a previous failure. Bonus points, we don't get tons of timeout-based errors, speeding up testing. > > That buildbot should be fixed to configure gdb with libexpat available, IMO. You're right, and I'll try to do that. Do we need some specific configure option? or is it just that the container (probably) doesn't have expat and thus configure is automatically skipping it? I think the test could be improved either way. > > Or could it be that expat is supposedly available but it fails to build with Clang? > That would be very surprising, though. > More of an FIY than anything. The "clang" buildbot still builds GDB with gcc, it just uses clang for the testsuite, so it's not about expat problems with clang. -- Cheers, Guinevere Larsen She/Her/Hers