From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 01812385783F for ; Tue, 18 Jul 2023 12:54:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 01812385783F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLkDZ-0000Q9-Ex; Tue, 18 Jul 2023 08:54:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=UU+EV46ebF8SGqP5ZrkcFA94hpEsPJ/5AEBgmFfimbM=; b=aV1viANZhI6R 2dyvY2xNBsN5uO2h163VeXZ+YLgHl+IATlxU/MhRU8QGRkyBD81J3dyIjrCjEUj/EC4T8Ucm/InvW tZTCaooq1MY+n5u+nwfQGYZ+7M00nnzEFNMF4RNVLHoqqzvT6SKt5lVolRgI6CCI+8WyHbb6w+M3f YREacpJ69ZLSYSjlpnShDNP/U62vr7dUUGvPaSzgj2dTdqeZ6u5hS3HKxAWf53B7tCHiaDB5J/Uy9 sj2IQQNXun84lKWmdGJYSSpiGhhIcqx37MPuKRueieO0EtKDixIwuIGGkpTNO5FsJlxei8l6TlZMA ivy6lBRp6nN3srXjn5+c6w==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLkDY-0006XK-Ue; Tue, 18 Jul 2023 08:54:17 -0400 Date: Tue, 18 Jul 2023 15:54:44 +0300 Message-Id: <83a5vt752j.fsf@gnu.org> From: Eli Zaretskii To: Bruno Larsen Cc: gdb-patches@sourceware.org In-Reply-To: <20230718112140.1911522-2-blarsen@redhat.com> (message from Bruno Larsen via Gdb-patches on Tue, 18 Jul 2023 13:21:41 +0200) Subject: Re: [PATCH] gdb/cli: fixes to newly added "list ." command References: <835af40f-edae-ba48-f121-a1cdd1f1147e@palves.net> <20230718112140.1911522-2-blarsen@redhat.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Cc: Bruno Larsen > Date: Tue, 18 Jul 2023 13:21:41 +0200 > From: Bruno Larsen via Gdb-patches > > diff --git a/gdb/NEWS b/gdb/NEWS > index ac5dc424d3f..dd2fc0103bc 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -87,8 +87,9 @@ > * The Ada 2022 Enum_Rep and Enum_Val attributes are now supported. > > * The 'list' command now accepts '.' as an argument, which tells GDB to > - print the location where the inferior is stopped. If the inferior hasn't > - started yet, the command will print around the main function. > + print the location around the last solitary line printed as part of > + displaying a stack frame. If the inferior hasn't started yet, the > + command will print around the main function. "Last solitary line" is not necessarily clear (why "solitary"?). How about * The 'list' command now accepts '.' as an argument, which tells GDB to print source code around the default location. The default location is where the inferior stopped; if the inferior didn't start yet, the command will print around the beginning of the 'main' function. > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -9155,9 +9155,9 @@ Same as using with no arguments. > Print lines just before the lines last printed. > > @item list . > -Print the lines surrounding the location that is where the inferior > -is stopped. If the inferior is not running, print around the main > -function instead. > +Print the lines surrounding the last solitary line printed as part > +of displaying a fram. If the inferior is not running, print around > +the main function instead. > @end table Same here. Thanks. Reviewed-By: Eli Zaretskii