From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 5638E3858CDB for ; Thu, 1 Jun 2023 06:15:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5638E3858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4bbF-0006Fo-Ms; Thu, 01 Jun 2023 02:15:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qXGEWDoFLOa5wAHXN48cmYomKSlWcLjSGQ/r4EJHLB8=; b=cKuUrWecGIqc vrUFcL4DcxG2MwgMDqgbkfNvaifYagciWnxXkgL6hBvy2zPP1Ec+898nbHp33AdeMyusd4bhI5OfF IC7rdJzA6BgdwyDgj3lN9p/4AOTm6rvJlp/If34B4302CfY3RzZTftXaZswqjMs3TepbUf3IYCdCF 7fkQzGRLjx+1JQQ0KKVQjJOvKh7h5EPubNobnE0JO8CGCiL5TCVz4Yzc36Fhe+VwfZG2pSW8CJpVG zDZc5NN+gvlvztQOBkbovb83x6iQ2hIbcoezf3nSRq7f+dNZOrp83EqIJbGQ78rgu1DCn79PcypVJ QF/8oowpbYDsPjTnYUS83A==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4bbF-0002Wm-3N; Thu, 01 Jun 2023 02:15:53 -0400 Date: Thu, 01 Jun 2023 09:16:38 +0300 Message-Id: <83a5xjemgp.fsf@gnu.org> From: Eli Zaretskii To: Aaron Merey Cc: gdb-patches@sourceware.org, aburgess@redhat.com In-Reply-To: <20230601014347.3367489-4-amerey@redhat.com> (message from Aaron Merey via Gdb-patches on Wed, 31 May 2023 21:43:44 -0400) Subject: Re: [PATCH 3/6 v3] gdb: Buffer gdb_stdout during events that might download deferred debuginfo References: <20230601014347.3367489-1-amerey@redhat.com> <20230601014347.3367489-4-amerey@redhat.com> X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Cc: aburgess@redhat.com, > Aaron Merey > Date: Wed, 31 May 2023 21:43:44 -0400 > From: Aaron Merey via Gdb-patches > > diff --git a/gdb/debuginfod-support.c b/gdb/debuginfod-support.c > index 6d0521b64e2..548e8c5f76b 100644 > --- a/gdb/debuginfod-support.c > +++ b/gdb/debuginfod-support.c > @@ -168,7 +168,8 @@ progressfn (debuginfod_client *c, long cur, long total) > > if (check_quit_flag ()) > { > - gdb_printf ("Cancelling download of %s %s...\n", > + ui_file *outstream = buffer_file::get_unbuffered_stream (gdb_stdout); > + gdb_printf (outstream, "Cancelling download of %s %s...\n", > data->desc, styled_fname.c_str ()); A nit: this is a user-level message, so I think it should be in _().