From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 61CD8385842C for ; Fri, 26 May 2023 09:52:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 61CD8385842C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2U82-0001d6-Su; Fri, 26 May 2023 05:52:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=imVjM5HfYXT9M2G0fLOxKQLcc2o6+nus0a5yLad1kGw=; b=fpKlwmXz/1A3 TT08dqoOOwmXYrmFbH7CiH7ZIYEV4IxdkDagcg0iWqcDy4dYi2Tk8AvE/VCRbOom8N7DyMRUQ6tO6 6x6meXkoqWbqvJife2pKDbIC3EcLYAbtasiQ7ajcWiU2lYp0qmb+tIUgkKkyXumLkV81XHuI66b30 jnqDO/doeU9nImWbiDhDAh5plIKn2A6l9GhiaH7z8r4s99EwoNCN70XOecF2QDQR6HkTcnSr/7uiO IbpFwEPI/3yomW5VD+b+shnJw/8yab29KD2NHlSkBJ8l7mF+zHn7XJG5Ui4z43vqwaqkCe+NOInPS KAz4Tqe0F5DIIaAecL5tSQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2U82-0002wP-BU; Fri, 26 May 2023 05:52:58 -0400 Date: Fri, 26 May 2023 12:53:29 +0300 Message-Id: <83a5xrl8py.fsf@gnu.org> From: Eli Zaretskii To: Simon Farre Cc: gdb-patches@sourceware.org In-Reply-To: <20230524175246.232007-1-simon.farre.cx@gmail.com> (message from Simon Farre via Gdb-patches on Wed, 24 May 2023 19:52:46 +0200) Subject: Re: [PATCH v3] [gdb/infcmd]: Add next-expression command References: <20230524175246.232007-1-simon.farre.cx@gmail.com> X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Cc: Simon Farre > Date: Wed, 24 May 2023 19:52:46 +0200 > From: Simon Farre via Gdb-patches > > --- > gdb/NEWS | 7 + > gdb/buildsym-legacy.c | 4 +- > gdb/buildsym-legacy.h | 2 +- > gdb/buildsym.c | 3 +- > gdb/buildsym.h | 4 +- > gdb/coffread.c | 4 +- > gdb/dbxread.c | 6 +- > gdb/doc/gdb.texinfo | 33 +- > gdb/doc/python.texi | 6 + > gdb/dwarf2/read.c | 32 +- > gdb/gdbthread.h | 3 + > gdb/infcmd.c | 327 ++++++++++++++++-- > gdb/infrun.c | 6 +- > gdb/linespec.c | 4 +- > gdb/linespec.h | 2 +- > gdb/mdebugread.c | 2 +- > gdb/python/py-symtab.c | 29 +- > gdb/stack.c | 22 ++ > gdb/symmisc.c | 4 +- > gdb/symtab.c | 1 + > gdb/symtab.h | 22 ++ > gdb/testsuite/gdb.base/annota1.exp | 4 +- > gdb/testsuite/gdb.base/annota3.exp | 6 +- > gdb/testsuite/gdb.base/dlmopen.exp | 2 +- > .../gdb.base/empty-host-env-vars.exp | 1 + > gdb/testsuite/gdb.base/gcore.exp | 1 + > gdb/testsuite/gdb.base/maint.exp | 11 +- > gdb/testsuite/gdb.base/next-expression.c | 113 ++++++ > gdb/testsuite/gdb.base/next-expression.exp | 267 ++++++++++++++ > gdb/testsuite/gdb.cp/annota3.exp | 2 +- > .../dw2-out-of-range-end-of-seq.exp | 4 +- > gdb/testsuite/gdb.dwarf2/dw2-ranges-base.exp | 6 +- > gdb/testsuite/gdb.mi/mi-async.exp | 2 +- > .../process-dies-while-handling-bp.exp | 2 +- > gdb/testsuite/lib/gdb-utils.exp | 2 + > gdb/testsuite/lib/gdb.exp | 2 +- > 36 files changed, 862 insertions(+), 86 deletions(-) > create mode 100644 gdb/testsuite/gdb.base/next-expression.c > create mode 100644 gdb/testsuite/gdb.base/next-expression.exp Thanks, the documentation parts of this are OK. Reviewed-By: Eli Zaretskii