From: Eli Zaretskii <eliz@gnu.org>
To: "Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] gdb: add a '-stopped' option to "info threads"
Date: Wed, 05 Apr 2023 14:56:34 +0300 [thread overview]
Message-ID: <83a5zmsft9.fsf@gnu.org> (raw)
In-Reply-To: <DM4PR11MB7303076CBB2C683A81352102C4909@DM4PR11MB7303.namprd11.prod.outlook.com> (tankut.baris.aktemur@intel.com)
> From: "Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>
> Date: Wed, 5 Apr 2023 11:31:16 +0000
>
> On Wednesday, April 5, 2023 12:51 PM, Eli Zaretskii wrote:
> > > From: "Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>
> > > Date: Wed, 5 Apr 2023 10:19:26 +0000
> > >
> > > I'm fine if we make the single thread id a special case.
> >
> > Maybe that's all we should do.
> >
> > > But then the question is, where do we draw the line? If the user
> > > gave just a few thread ids, do we still ignore the flag? What is
> > > the limit to the acceptable list length? Because of these
> > > questions, consistently applying the flag made more sense to me.
> >
> > We don't have to be 100% consistent, we just need to be useful.
>
> Let's please wait a bit in case other maintainers want to chime in.
Sure. I just expressed my personal opinion, not a request to make
changes in your patches right away.
prev parent reply other threads:[~2023-04-05 11:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 9:19 [PATCH 0/3] Option to show stopped threads only Tankut Baris Aktemur
2023-04-05 9:20 ` [PATCH 1/3] gdb: pass info_threads_opts to print_thread_info_1 Tankut Baris Aktemur
2023-04-05 9:20 ` [PATCH 2/3] gdb, doc: add the missing '-gid' option to 'info threads' Tankut Baris Aktemur
2023-04-05 9:56 ` Eli Zaretskii
2023-04-05 10:12 ` Aktemur, Tankut Baris
2023-04-05 9:20 ` [PATCH 3/3] gdb: add a '-stopped' option to "info threads" Tankut Baris Aktemur
2023-04-05 10:00 ` Eli Zaretskii
2023-04-05 10:19 ` Aktemur, Tankut Baris
2023-04-05 10:50 ` Eli Zaretskii
2023-04-05 11:31 ` Aktemur, Tankut Baris
2023-04-05 11:56 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a5zmsft9.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tankut.baris.aktemur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).