From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 31BB73858D35 for ; Thu, 12 Jan 2023 09:41:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 31BB73858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFu5m-000159-TT; Thu, 12 Jan 2023 04:41:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=PK0re5jt2WXQFdLG0cs+2QPD22TRtHuKxzmz5RuOiQw=; b=nEiJVKjZavrc 9HHycP/J2GqdV0IyHBEbtfeVJGLPO07T8Q7/hrNzrLPRGnvS0j7m2hOL0GL7esIAJJ62B2gjhow68 Zgx38RwS2WjOE+Gtx8K9/XaQWs9ISptQcjO9Rv9cM9bHR9bZhFDIlLuVe4HGcxm/bDUQIQ6wwJ5sH 7wx+pc3G/1QCZhDq54LE8FAxkAAkz2jFgqE4ije+B91gjySRkP26RZbZj4vuFNN8Z2DoPf2ApC3vs kOFzqebgc9AUiocG6fNYVBZoh8VDjJ1JmSoqeWC7c8udggNjN6POwKLKzcKHLorOCD1ng+ctivF7F qy4O+Qu9pSFuscGOoyVieQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFu5l-0000nq-Qm; Thu, 12 Jan 2023 04:41:50 -0500 Date: Thu, 12 Jan 2023 11:42:24 +0200 Message-Id: <83a62oks1r.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey Cc: gdb-patches@sourceware.org In-Reply-To: <87eds16kqy.fsf@tromey.com> (message from Tom Tromey on Wed, 11 Jan 2023 10:31:33 -0700) Subject: Re: [PATCH 3/3] Let Python breakpoints be created silently References: <20221208191804.3819129-1-tromey@adacore.com> <20221208191804.3819129-4-tromey@adacore.com> <87eds16kqy.fsf@tromey.com> X-Spam-Status: No, score=1.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Tom Tromey > Cc: Tom Tromey , Eli Zaretskii > Date: Wed, 11 Jan 2023 10:31:33 -0700 > > >>>>> "Tom" == Tom Tromey via Gdb-patches writes: > > Tom> Currently, a breakpoint created from Python will always announce its > Tom> presence; and in some cases (for example a pending breakpoint), other > Tom> information will be printed as well. > > Tom> When scripting gdb, it's useful to be able to control the output in > Tom> cases like this. I debated whether to simply disable the output > Tom> entirely, but I thought perhaps some existing code acts as a simple > Tom> "break"-like command and wants the output. > > Tom> This patch adds a new "announce" flag to gdb.Breakpoint. Setting this > Tom> to False will cause gdb to be silent here. > > I think this one still needs a documentation review. Sorry for missing it. The patch is okay, with a single gotcha: > +The optional @var{announce} argument is a boolean that controls > +whether @var{GDBN} announces the existence of the breakpoint. The ^^^^ That should be @value, not @var.