From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [209.51.188.92])
 by sourceware.org (Postfix) with ESMTPS id BEFF73858C56
 for <gdb-patches@sourceware.org>; Tue, 21 Jun 2022 11:07:55 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BEFF73858C56
Received: from fencepost.gnu.org ([2001:470:142:3::e]:42398)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1o3bje-00049M-RM; Tue, 21 Jun 2022 07:07:54 -0400
Received: from [87.69.77.57] (port=4209 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1o3bje-0000kW-C4; Tue, 21 Jun 2022 07:07:54 -0400
Date: Tue, 21 Jun 2022 14:07:43 +0300
Message-Id: <83a6a6l1fk.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <pedro@palves.net>
Cc: gdb-patches@sourceware.org
In-Reply-To: <20220620225419.382221-20-pedro@palves.net> (message from Pedro
 Alves on Mon, 20 Jun 2022 23:54:13 +0100)
Subject: Re: [PATCH 19/25] Don't resume new threads if scheduler-locking is in
 effect
References: <20220620225419.382221-1-pedro@palves.net>
 <20220620225419.382221-20-pedro@palves.net>
X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Jun 2022 11:07:57 -0000

> From: Pedro Alves <pedro@palves.net>
> Date: Mon, 20 Jun 2022 23:54:13 +0100
> 
> diff --git a/gdb/NEWS b/gdb/NEWS
> index 5576c355b7a..2e842cb00f9 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -3,6 +3,9 @@
>  
>  *** Changes since GDB 12
>  
> +* If supported by the target, when scheduler-locking is in effect, new
> +  threads created by the resumed thread are held stopped.
                        ^^^^^^^^^^^^^^^^^^
"a resumed thread", I guess?

> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index b3e995f166b..775c4b1347b 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -6932,6 +6932,9 @@ current thread away from the thread that you are debugging.  The
>  @code{replay} mode behaves like @code{off} in record mode and like
>  @code{on} in replay mode.
>  
> +If supported by the target, when scheduler-locking is in effect, new
> +threads created by the resumed thread are held stopped.

Same here, but maybe the following slight rewording will make the
sentence simpler:

  When scheduler-locking is supported by the target and is in effect,
  new threads created by a resumed thread are held stopped.

The documentation parts are okay with these nits fixed.