From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id 6B3293952498
 for <gdb-patches@sourceware.org>; Fri,  6 May 2022 11:51:08 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6B3293952498
Received: from fencepost.gnu.org ([2001:470:142:3::e]:43084)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nmwUF-0000ZB-Uf; Fri, 06 May 2022 07:51:07 -0400
Received: from [87.69.77.57] (port=4274 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nmwUF-0007r3-DF; Fri, 06 May 2022 07:51:07 -0400
Date: Fri, 06 May 2022 14:50:56 +0300
Message-Id: <83a6bu282n.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Felix Willgerodt <felix.willgerodt@intel.com>
Cc: markus.t.metzger@intel.com, gdb-patches@sourceware.org
In-Reply-To: <20220506114010.134106-6-felix.willgerodt@intel.com> (message
 from Felix Willgerodt via Gdb-patches on Fri, 6 May 2022 13:40:06
 +0200)
Subject: Re: [PATCH v4 06/10] python: Add clear() to gdb.Record.
References: <20220506114010.134106-1-felix.willgerodt@intel.com>
 <20220506114010.134106-6-felix.willgerodt@intel.com>
X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 06 May 2022 11:51:09 -0000

> Date: Fri,  6 May 2022 13:40:06 +0200
> From: Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org>
> 
> This function allows to clear the trace data from python, forcing to
> re-decode the trace for successive commands.
> ---
>  gdb/doc/python.texi                           |  5 +++++
>  gdb/python/py-record-btrace.c                 | 13 +++++++++++++
>  gdb/python/py-record-btrace.h                 |  3 +++
>  gdb/python/py-record.c                        | 16 ++++++++++++++++
>  gdb/testsuite/gdb.python/py-record-btrace.exp |  6 +++++-
>  5 files changed, 42 insertions(+), 1 deletion(-)
> 
> diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
> index 142dbc719a4..707aa5c3ee3 100644
> --- a/gdb/doc/python.texi
> +++ b/gdb/doc/python.texi
> @@ -3779,6 +3779,11 @@ A @code{gdb.Record} object has the following methods:
>  Move the replay position to the given @var{instruction}.
>  @end defun
>  
> +@defun Record.clear ()
> +Clear the trace data of the current recording.  This forces re-decoding of the
> +trace for successive commands.
> +@end defun

What does "force re-decoding" mean here?  If this is described in
another place in the manual, could you add a cross-reference to that
place?

Otherwise, the documentation part is OK, thanks.