Re: [PATCHv2 3/5] gdb/mi: add regexp filtering to -file-list-exec-source-files

[Eli Zaretskii <eliz@gnu.org>]

> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Wed, 19 May 2021 12:12:40 +0100
> 
> This commit extends the existing MI command
> -file-list-exec-source-files to provide the same regular expression
> based filtering that the equivalent CLI command "info sources"
> provides.
> 
> The new command syntax is:
> 
>   -file-list-exec-source-files [--basename | --dirname] [--] [REGEXP]

Thanks.

> + ** '-file-list-exec-source-files [--basename | --dirname] [--] [REGEXP]'
> +
> +    The existing -file-list-exec-source-files command now takes an
> +    optional REGEXP which is used to filter the source files that are
> +    included in the results.  By default REGEXP is matched against the
> +    full filename of the source file.
> +
> +    When one of --basename or --dirname is given then REGEXP is only
> +    matched against the specified part of the full source filename.

It is better to make the last sentence of the first paragraph to be
the first sentence of the second paragraph, since these describe the
same aspect of using REGEXP.

> +This commands returns information about the source files @value{GDBN}
> +knows about, it will output both the filename and fullname (absolute
> +file name) of a source file, though the fullname can be elided if this
> +information is not known.
               ^^^^^^^^^^^^
I'd suggest to say "is not known to @value{GDBN}", to make the issue
more clear.

> +name of the source file can't be computed. The field
                                            ^^
Two spaces between sentences, please (here and elsewhere).

> +@var{debug-fully-read} will be a string, either @code{true} or
> +@code{false}.  When @code{true} this indicates the full debug
                                  ^
Comma is missing there.

> +information for the compilation unit describing this file has been
> +read in.  When @code{false} the full debug information has not yet
                              ^
And there.

> +@value{GDBN} interpreting @var{regexp} as a command option (e.g. if
> +@var{regexp} starts with @samp{-}).

Please add either a comma or "@:" (without quotes) after "e.g.", so
that TeX won't interpret that as ending a sentence.

> +If @code{--dirname} is provided then @var{regexp} is matched only
                                  ^
Comma missing.

> +against the directory name of each source file.  If @code{--basename}
> +is provided then @var{regexp} is matched against the basename of each
              ^
And here.