From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 8751B385DC35 for ; Fri, 26 Jun 2020 10:23:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8751B385DC35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eliz@gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]:59024) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jolWK-00013E-DR; Fri, 26 Jun 2020 06:23:44 -0400 Received: from [176.228.60.248] (port=3873 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jolWJ-0006ld-Ot; Fri, 26 Jun 2020 06:23:44 -0400 Date: Fri, 26 Jun 2020 13:23:26 +0300 Message-Id: <83a70qruqp.fsf@gnu.org> From: Eli Zaretskii To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: gdb-patches@sourceware.org In-Reply-To: <20200626081333.23412-2-ludo@gnu.org> (message from Ludovic =?utf-8?Q?Court=C3=A8s?= on Fri, 26 Jun 2020 10:13:32 +0200) Subject: Re: [PATCH v3 1/2] guile: Add support for Guile 2.2. References: <87k103ik0v.fsf@gnu.org> <20200626081333.23412-1-ludo@gnu.org> <20200626081333.23412-2-ludo@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jun 2020 10:23:54 -0000 > From: Ludovic Courtès > Date: Fri, 26 Jun 2020 10:13:32 +0200 > Cc: Ludovic Courtès > > diff --git a/gdb/NEWS b/gdb/NEWS > index a116d62bca..37ab83618e 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -117,6 +117,16 @@ GNU/Linux/RISC-V (gdbserver) riscv*-*-linux* > ** Commands written in Python can be in the "TUI" help class by > registering with the new constant gdb.COMMAND_TUI. > > +* Guile API > + > + ** GDB can now be built with GNU Guile 2.2 in addition to 2.0. > + > + ** Procedures 'memory-port-read-buffer-size', > + 'set-memory-port-read-buffer-size!', 'memory-port-write-buffer-size', > + and 'set-memory-port-write-buffer-size!' are deprecated. When > + using Guile 2.2 and later, users who need to control the size of > + a memory port's internal buffer can use the 'setvbuf' procedure. > + This part is OK. > @deffn {Scheme Procedure} set-memory-port-read-buffer-size! memory-port size > Set the size of the read buffer of @code{} > @var{memory-port} to @var{size}. The result is unspecified. > + > +This procedure is deprecated and will be removed in @value{GDBN} 11. > +When using Guile 2.2 or later, you can call @code{setvbuf} instead > +(@pxref{Buffering, @code{setvbuf},, guile, GNU Guile Reference Manual}). First, instead of "When using" I'd suggest to say "When @value{GDBN} was built with". And second, there's a certain conundrum here: the node "Buffering" doesn't exist in the Guile v2.0.x manual, so I wonder whether we should say something here about that to prevent user surprise when the hyperlink causes an error. > @deffn {Scheme Procedure} set-memory-port-write-buffer-size! memory-port size > Set the size of the write buffer of @code{} > @var{memory-port} to @var{size}. The result is unspecified. > + > +This procedure is deprecated and will be removed in @value{GDBN} 11. > +When using Guile 2.2 or later, you can call @code{setvbuf} instead > +(@pxref{Buffering, @code{setvbuf},, guile, GNU Guile Reference Manual}). > @end deffn Here, I'd remove the @pxref: we already have the same hyperlink a short ways above, so repetition is not necessary. The documentation parts are okay with those nits fixed. > +/* Whether we're using Guile < 2.2 and its clumsy port API. */ > + > +#define USING_GUILE_BEFORE_2_2 \ > + (SCM_MAJOR_VERSION < 2 \ > + || (SCM_MAJOR_VERSION == 2 && SCM_MINOR_VERSION == 0)) Since Guile < 2.0 is not supported, do we need the first part of the macro? Thanks.