From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gdb: New maintenance command to print XML target description
Date: Thu, 11 Jun 2020 16:27:45 +0300 [thread overview]
Message-ID: <83a71968by.fsf@gnu.org> (raw)
In-Reply-To: <1247d74ec150f017e7ac1fea946af1d3da7ea79e.1591871818.git.andrew.burgess@embecosm.com> (message from Andrew Burgess on Thu, 11 Jun 2020 11:41:31 +0100)
> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Thu, 11 Jun 2020 11:41:31 +0100
>
> gdbsupport/ChangeLog:
>
> * tdesc.cc (print_xml_feature::visit_pre): Use add_line to add
> output content, and call indent as needed in all overloaded
> variants.
> (print_xml_feature::visit_post): Likewise.
> (print_xml_feature::visit): Likewise.
> (print_xml_feature::add_line): Two new overloaded functions.
> * tdesc.h (print_xml_feature::indent): Declare new member
> function.
> (print_xml_feature::add_line): Two new overloaded member
> functions.
>
> gdb/ChangeLog:
>
> * target-descriptions.c (tdesc_architecture_name): Protect against
> NULL pointer dereference.
> (class gdb_print_xml_feature): New class.
> (maint_print_xml_tdesc_cmd): New function.
> (_initialize_target_descriptions): Register new 'maint print
> xml-tdesc' command and give it the filename completer.
> * NEWS: Mention new 'maint print xml-tdesc' command.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.xml/maint-xml-dump-01.xml: New file.
> * gdb.xml/maint-xml-dump-02.xml: New file.
> * gdb.xml/maint-xml-dump.exp: New file.
>
> gdb/doc/ChangeLog:
>
> * gdb.texinfo (Maintenance Commands): Document new 'maint print
> xml-desc' command.
OK for the documentation changes.
Thanks.
next prev parent reply other threads:[~2020-06-11 13:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 10:41 [PATCH 0/2] Additional maintenance command for dumping target descriptions Andrew Burgess
2020-06-11 10:41 ` [PATCH 1/2] gdb: Allow target description to be dumped even when it is remote Andrew Burgess
2020-06-11 11:33 ` Pedro Alves
2020-06-11 14:05 ` Andrew Burgess
2020-06-11 14:24 ` Pedro Alves
2020-06-11 10:41 ` [PATCH 2/2] gdb: New maintenance command to print XML target description Andrew Burgess
2020-06-11 13:10 ` Pedro Alves
2020-06-11 13:27 ` Eli Zaretskii [this message]
2020-06-11 19:50 ` [PATCH 0/2] Additional maintenance command for dumping target descriptions Christian Biesinger
2020-06-16 20:51 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a71968by.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).