From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC 3/3] Deprecate and replace the "tabset" command
Date: Mon, 03 Sep 2018 18:58:00 -0000 [thread overview]
Message-ID: <83a7oyz9vc.fsf@gnu.org> (raw)
In-Reply-To: <20180903184300.9961-4-tom@tromey.com> (message from Tom Tromey on Mon, 3 Sep 2018 12:43:00 -0600)
> From: Tom Tromey <tom@tromey.com>
> Cc: Tom Tromey <tom@tromey.com>
> Date: Mon, 3 Sep 2018 12:43:00 -0600
>
> The "tabset" command sets the tab width as used by the TUI for source
> and disassembly display.
>
> This command has long seemed to be misnamed to me. It is more in
> keeping with gdb design to call it "set tui tab-width". Also, making
> this change allows for the corresponding "show" command to work.
>
> gdb/ChangeLog
> 2018-09-03 Tom Tromey <tom@tromey.com>
>
> PR tui/18388:
> * NEWS: Mention tabset deprecation.
> * tui/tui-win.c (tui_tab_width, internal_tab_width): New globals.
> (update_tab_width): New function.
> (tui_set_tab_width, tui_show_tab_width): New functions.
> (tui_set_tab_width_command): Use update_tab_width.
> (_initialize_tui_win): Move to end of file. Deprecate "tabset".
> Add new "set tui tab-width" command.
> * tui/tui-source.c (tui_set_source_content): Update.
> * tui/tui-disasm.c (tui_set_disassem_content): Update.
> * tui/tui-data.h (tui_default_tab_len, tui_set_default_tab_len):
> Don't declare.
> (tui_tab_width): Declare.
> * tui/tui-data.c (default_tab_len, tui_default_tab_len)
> (tui_set_default_tab_len): Remove.
>
> gdb/doc/ChangeLog
> 2018-09-03 Tom Tromey <tom@tromey.com>
>
> PR tui/18388:
> * gdb.texinfo (TUI Commands): Remove tabset documentation.
> (TUI Configuration): Document "set tui tab-width".
OK for the documentation parts.
Thanks.
next prev parent reply other threads:[~2018-09-03 18:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 18:43 [RFC 0/3] Some TUI fixes Tom Tromey
2018-09-03 18:43 ` [RFC 2/3] Making ANSI terminal escape sequences work in TUI Tom Tromey
2018-10-11 23:04 ` Tom Tromey
2018-09-03 18:43 ` [RFC 1/3] Minor cleanups in tui-io.c Tom Tromey
2018-09-03 18:43 ` [RFC 3/3] Deprecate and replace the "tabset" command Tom Tromey
2018-09-03 18:58 ` Eli Zaretskii [this message]
2018-10-18 21:42 ` [RFC 0/3] Some TUI fixes Tom Tromey
2018-10-18 22:04 ` Tom Tromey
2018-10-19 23:20 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a7oyz9vc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).