From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20978 invoked by alias); 24 Jan 2015 12:32:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20935 invoked by uid 89); 24 Jan 2015 12:32:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout26.012.net.il Received: from mtaout26.012.net.il (HELO mtaout26.012.net.il) (80.179.55.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 24 Jan 2015 12:32:15 +0000 Received: from conversion-daemon.mtaout26.012.net.il by mtaout26.012.net.il (HyperSendmail v2007.08) id <0NIO00A00LEH0000@mtaout26.012.net.il> for gdb-patches@sourceware.org; Sat, 24 Jan 2015 14:32:05 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout26.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NIO007I7LHHTL30@mtaout26.012.net.il>; Sat, 24 Jan 2015 14:32:05 +0200 (IST) Date: Sat, 24 Jan 2015 14:15:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH] TUI: Expand TABs into spaces In-reply-to: To: Doug Evans Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83a918s6k5.fsf@gnu.org> References: <83k3149k5b.fsf@gnu.org> <837fwn2cvc.fsf@gnu.org> X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00667.txt.bz2 Ping! Ping! OK to install? > Date: Fri, 16 Jan 2015 08:32:15 -0800 > From: Doug Evans > Cc: "gdb-patches@sourceware.org" > > On Fri, Jan 16, 2015 at 3:17 AM, Eli Zaretskii wrote: > > Ping! OK to install, master and 7.9 branch? > > > >> Date: Sat, 03 Jan 2015 13:30:08 +0200 > >> From: Eli Zaretskii > >> > >> "gdb -tui" relies on the curses library and the underlying terminal > >> driver to expand TAB characters into spaces. But ncurses on Windows > >> doesn't do that, and instead displays an IBM graphics character. > >> > >> The patches below fix that in the command window and in displaying the > >> registers. > >> > >> OK to commit? > >> > >> 2015-01-03 Eli Zaretskii > >> > >> * tui/tui-regs.c (tui_register_format): Expand TABs into the > >> appropriate number of spaces. > >> > >> * tui/tui-io.c (tui_puts, tui_redisplay_readline): Expand TABs > >> into the appropriate number of spaces. > > I'd have to read the patch more to say it's ok, > but one thing that is missing are comments > explaining *why* we are expanding tabs into spaces. >