From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 1D0553858CDB for ; Fri, 8 Dec 2023 19:25:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1D0553858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1D0553858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702063558; cv=none; b=dttq1yDMQeItnXs6KkvV7/0QLCzz5E0Xkc5wMRCZ2v+zYYh8xXZD4FFW5LGho0byI471GW3vaoBg/FqsT2BLnjsaRWq34VJmmcFVDXdwMYw4/r2EIDywHFxx4xrXvu6dz5xHY0GP4r/2rdSZB7Sfw0dcxf2gkOvMNlUNyU3A0Mg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702063558; c=relaxed/simple; bh=v4dZ3cL9XcSHzYsfB4tJ0FKdLOlcsTdUoxM3UzB46y8=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=G/HmRHow2gJ8yFY9OdMnOQUj7EpU4GB+sU+l4DEEoBxIe/tRNlo2kSfq5T6lHYBkJrcA04968e5XZhkufwuI3ql312m7VPsp4gVK9B9kGgGbsGO5W5O2vfKHkKucIYGxiIW1GjOQ+1zollJPmGyjpTHVCzTSVXhhUjPtjGero3I= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBgU0-0008KG-Fm; Fri, 08 Dec 2023 14:25:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=RirHwLMLFAyy/RNJiUmP4VMpBg8NwYnjJ5bPvxcm/RE=; b=SxHyg46/xvB5 +fSKbIfdxqtf5YVxoLpDx/LX0i+9g2se4ZbiOEkOjXY7MYGYvft9chqo86v2nEOtbPi2Fh5ScDgsP gMgrZ+Pla8B8lLMNG0cK8GkiefcN6pGqAxUaAnMkWqFIUQoKCnukadalod2/3ET+jgPGcfqK/ksPY SJRWwBTZCJAX7CMciHnHJAWzipJyhN1STgTPhF99aOkdmZOYCyQPtxDqypfXDyddhDaF52ZqpA61o u6z9JemrJuxzmEQOYGz3r/TpUa0hU4ml+Q3JcPaMUQC9EDin7R2bq8a4Rs1g069xKz62dMcS6N0wV 8qU805Hj+fQY/ODV1coePg==; Date: Fri, 08 Dec 2023 21:25:48 +0200 Message-Id: <83bkb0zebn.fsf@gnu.org> From: Eli Zaretskii To: Tom de Vries Cc: gdb-patches@sourceware.org In-Reply-To: <20231208165025.10973-1-tdevries@suse.de> (message from Tom de Vries on Fri, 8 Dec 2023 17:50:25 +0100) Subject: Re: [PATCH v2] [gdb/tui] Show focus window in status line References: <20231208165025.10973-1-tdevries@suse.de> X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Tom de Vries > Cc: Eli Zaretskii > Date: Fri, 8 Dec 2023 17:50:25 +0100 > > The focused window is highlighted by using active-border-kind instead of > border-kind. > > But if the focused window is the cmd window (which is an unboxed window), then > no highlighting is done, and it's not obvious from looking at the screen which > window has the focus. Instead, you have to notice the absence of highlighting > on boxed windows, and then infer that the focus is on the unboxed window. > > That approach stops working if there are multiple unboxed windows. > > Likewise if highlighting is switched off by setting active-border-kind to the > same value as border-kind. > > Make it more explicit which window has the focus by mentioning it in the status > window, like so: > ... > native process 8282 (src) In: main L7 PC: 0x400525 > ... > > Tested on x86_64-linux and ppc64le-linux. > > Tested-By: Alexandra Petlanova Hajkova > --- > gdb/doc/gdb.texinfo | 3 +++ > gdb/testsuite/gdb.tui/single-key.exp | 4 ++-- > gdb/tui/tui-data.c | 2 ++ > gdb/tui/tui-stack.c | 16 ++++++++++++++++ > 4 files changed, 23 insertions(+), 2 deletions(-) The gdb.texinfo part is OK, thanks. Reviewed-By: Eli Zaretskii