From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id DFEAB3858D33 for ; Sat, 16 Sep 2023 05:34:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DFEAB3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhNx3-0005zq-39; Sat, 16 Sep 2023 01:34:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=CdRmW5l3Z7ms7Fp1tkKQrul1Z8uC09t9CtpjQo+9bCY=; b=P0WxSMyAYn6D 77kl5o/OuQrPMeWFs0gLn8rA7eLsb9Facoxo1HgtpzDNsJGb5Xzkd5wH29ocWQIJbGN3ZYgT3vy4x 7E6428NCKiMJj26zOM9wHPExvVGQH7fLU+G6z03LirkjVpfRWcvaoFI+FwRrP4XlRSkclUcXM7GsD nkh7Eju8xVMUidxjLMTp5zyV7HcaymDjmrHUPAV1NHHmedZUFJdaHPwsaNqIC/8zmc3m52s5JUNSJ veaLFgrgkqhohkkDxsnB1uoz8hZpW8Svy7YbEmG1kQ2vfuPQqj/O8BwHDhQEthmzTf/KZ+WyIIpiE OkQkCAhmRe+5PhgPj8s0Hw==; Date: Sat, 16 Sep 2023 08:34:33 +0300 Message-Id: <83bke2k7fa.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey Cc: gdb-patches@sourceware.org In-Reply-To: <20230916000908.110459-1-tom@tromey.com> (message from Tom Tromey on Fri, 15 Sep 2023 18:09:08 -0600) Subject: Re: [PATCH] Support the NO_COLOR environment variable References: <20230916000908.110459-1-tom@tromey.com> X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Tom Tromey > Cc: Tom Tromey > Date: Fri, 15 Sep 2023 18:09:08 -0600 > I ran across this site: > > https://no-color.org/ > > ... which lobbies for tools to recognize the NO_COLOR environment > variable and disable any terminal styling when it is seen. > > This patch implements this for gdb. Should we also support the --color command-line argument, e.g. to countermand NO_COLOR in the environment, and also as an alternative to the environment variable? > --- > gdb/NEWS | 4 ++++ > gdb/doc/gdb.texinfo | 3 +++ > gdb/main.c | 4 ++++ > gdb/testsuite/gdb.base/early-init-file.exp | 3 ++- > .../gdb.base/style-interp-exec-mi.exp | 3 ++- > gdb/testsuite/gdb.base/style-logging.exp | 3 ++- > gdb/testsuite/gdb.base/style.exp | 9 ++++++--- > .../build-id-no-debug-warning.exp | 3 ++- > gdb/testsuite/gdb.debuginfod/crc_mismatch.exp | 3 ++- > gdb/testsuite/gdb.python/py-format-string.exp | 3 ++- > gdb/testsuite/gdb.python/py-source-styling.exp | 3 ++- > gdb/testsuite/gdb.python/py-startup-opt.exp | 3 ++- > gdb/testsuite/gdb.rust/rust-style.exp | 3 ++- > gdb/testsuite/gdb.tui/tui-layout.exp | 18 +++++++++++------- > gdb/testsuite/lib/gdb.exp | 2 +- > gdb/testsuite/lib/tuiterm.exp | 3 ++- > 16 files changed, 49 insertions(+), 21 deletions(-) Thanks, the documentation parts of this are approved. Reviewed-By: Eli Zaretskii