public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 5/5] Add "save history" command
Date: Sun, 29 Jan 2023 18:56:32 +0200	[thread overview]
Message-ID: <83bkmh6zzz.fsf@gnu.org> (raw)
In-Reply-To: <20230129162105.526266-6-tom@tromey.com> (message from Tom Tromey on Sun, 29 Jan 2023 09:21:05 -0700)

> From: Tom Tromey <tom@tromey.com>
> Cc: Tom Tromey <tom@tromey.com>
> Date: Sun, 29 Jan 2023 09:21:05 -0700
> 
> PR cli/23664 points out that it would sometimes be convenient to
> immediately save the current history to a file.  This patch implements
> this feature.
> 
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=23664
> ---
>  gdb/NEWS                                |  3 +++
>  gdb/doc/gdb.texinfo                     |  8 ++++++
>  gdb/testsuite/gdb.base/save-history.exp | 36 +++++++++++++++++++++++++
>  gdb/top.c                               | 18 +++++++++++++
>  4 files changed, 65 insertions(+)
>  create mode 100644 gdb/testsuite/gdb.base/save-history.exp

The documentation parts are okay, thanks.

> +Occasionally you may want to save your history to a file.  This
> +command will do just that, saving the commands in your current session
> +to the named file.  Note that you should normally edit the saved
> +history before using @code{source} to reload it, as the @code{save
> +history} command itself will be at the end of the file.

What is the rationale for saving the "save history" command as well?
Are there any circumstances when the user might want that?

  reply	other threads:[~2023-01-29 16:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-29 16:21 [PATCH 0/5] Additions to "save" command Tom Tromey
2023-01-29 16:21 ` [PATCH 1/5] Save breakpoints so they are automatically pending Tom Tromey
2023-01-31 15:14   ` Alexandra Petlanova Hajkova
2023-01-29 16:21 ` [PATCH 2/5] Move show_user_1 to cli-cmds.c Tom Tromey
2023-01-29 16:21 ` [PATCH 3/5] Add "save user" command Tom Tromey
2023-01-29 16:57   ` Eli Zaretskii
2023-01-30 14:53   ` Pedro Alves
2023-01-30 23:35     ` Tom Tromey
2023-01-29 16:21 ` [PATCH 4/5] Add "save skip" command Tom Tromey
2023-01-29 16:54   ` Eli Zaretskii
2023-01-29 16:21 ` [PATCH 5/5] Add "save history" command Tom Tromey
2023-01-29 16:56   ` Eli Zaretskii [this message]
2023-01-30 14:50   ` Pedro Alves
2023-01-30 15:12     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83bkmh6zzz.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).