From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 98F9A3858D1E for ; Thu, 22 Dec 2022 07:01:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 98F9A3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p8FaM-0002os-3s; Thu, 22 Dec 2022 02:01:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=AxqhVlchSyG7Xuuvfr8mdx2j25i0a84Q46DQePPufbg=; b=bBR7V+DzU+6hSw9E85oq heBFuplm6TijrvOoCFjQGsMa3k021aa7VZRB47qimgjehYwxxE7YfqOf/sOCR2Bdy2xdtOkC4n6wl HxktLRFHf48KHk+QrABG9M5v4bAdyo9HojFonYbMee8mhEHa/P7XVo8wHAG2LO2WhMdNFWh0QSFyO sbM7Dkk5qvQLg2V7aczXUt8ArUIG3tdN6X6XC57SaHS6m5eq4UKGgg4ftAvhazFiz02BaEFYJofVw ZpTK0qM587VPPRYZvIqLXr7DgB2wWX6H1sPZy19Z/nktBHFog8Yoe8Hgmf2Y/4ZoGD5kIpL2YGuYw JNXwTryeYGU2hA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p8FaL-0001NR-JK; Thu, 22 Dec 2022 02:01:45 -0500 Date: Thu, 22 Dec 2022 09:01:30 +0200 Message-Id: <83bknvapmd.fsf@gnu.org> From: Eli Zaretskii To: Aaron Merey Cc: gdb-patches@sourceware.org, pedro@palves.net, tdevries@suse.de, mliska@suse.cz In-Reply-To: <20221221214730.112787-1-amerey@redhat.com> (message from Aaron Merey on Wed, 21 Dec 2022 16:47:30 -0500) Subject: Re: [PATCH v2] [gdb/debuginfod] Ask to cancel further downloads References: <83edsyigm0.fsf@gnu.org> <20221221214730.112787-1-amerey@redhat.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=1.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Aaron Merey > Cc: gdb-patches@sourceware.org, > pedro@palves.net, > tdevries@suse.de, > mliska@suse.cz, > Aaron Merey > Date: Wed, 21 Dec 2022 16:47:30 -0500 > > Hi Eli, > > Thanks for the review. I've updated the patch with your suggestions. > > On Sat, Dec 17, 2022 at 3:40 AM Eli Zaretskii wrote: > > > +cancel all further downloads before attempting to perform the next query. > >                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > I'm not sure I understand the emphasized part.  What do you mean by > > "before attempting"? > > Before attempting the next query, there will be a prompt asking whether > or not to cancel all further downloads in addition to the current download. > For clarity I've changed the wording: "Pressing @kbd{Ctrl-C} twice during > downloading will cancel the current download and prompt whether to cancel > all further downloads." That SGTM, thanks. > +@item set debuginfod cancel ask > +Pressing @kbd{Ctrl-C} twice during downloading will cancel the current > +download and prompt whether to cancel all further downloads. By default, Two spaces there, please. Other than that, the documentation part is OK.