From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [209.51.188.92]) by sourceware.org (Postfix) with ESMTPS id 5A947385842C for ; Tue, 20 Dec 2022 14:12:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5A947385842C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7dLc-0004HT-Al; Tue, 20 Dec 2022 09:12:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=hMraJ+lyFK3IJj3fLKUIgVa8lKv1iy9m9mhy2c+Hl+Q=; b=mbJdLtHgoJQm aNilxReXdYImeCTE/QkY/5hzQiLAMIaK6ZyA+WJx7JpmgKn9I624Gt5qch+V7/sjGacAN9iLb1oEw NOVl1opyEkyJ00UehzUpYbhdZuJA0+A2f5lEXhPsJoLWG7Lep8slXFuL3Mq4rWYhDQoJE4+1DXZ3P A7308cjALkMnW9ZeHqxMGBvZbG6BydEpMCGl2G4dbif/59ft/34Dbktmbzqeoblf8AjtkGOga4gQh em6FM8xCDF9eNoSSh/dVk+PAiRc0uxfr8zxKOlIRjexdtf+lCBVLbqQca4sol+KjwPyP/yeilv2bh 5ZHFLpDKb4M/ftfjjBnlxQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7dLb-00069t-Ry; Tue, 20 Dec 2022 09:12:00 -0500 Date: Tue, 20 Dec 2022 16:12:12 +0200 Message-Id: <83bknycgg3.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey , brobecker@adacore.com Cc: gdb-patches@sourceware.org In-Reply-To: <87len3ksec.fsf@tromey.com> (message from Tom Tromey on Mon, 19 Dec 2022 14:14:35 -0700) Subject: Re: MinGW build of GDB 13 snapshot References: <83k02qgdbo.fsf@gnu.org> <87len3ksec.fsf@tromey.com> X-Spam-Status: No, score=1.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Tom Tromey > Cc: Eli Zaretskii , Joel Brobecker > Date: Mon, 19 Dec 2022 14:14:35 -0700 > > >>>>> "Eli" == Eli Zaretskii via Gdb-patches writes: > > Eli> One of those issues is in the bfd directory, and I will report it to > Eli> the Binutils list. I'm asking here what to do with that issue > Eli> meanwhile: do I install a fix for it in our copy of bfd, or do I wait > Eli> for Binutils folks to fix it up-stream? The fix is simple: > > IMO it's fine to put on the gdb 13 branch. > I suppose if binutils wants changes we can consider putting their > approved version on the branch instead. The problem is now fixed in upstream Binutils, see https://sourceware.org/bugzilla/show_bug.cgi?id=29915 So I think I will fix this on the gdb 13 branch only, and master will be fixed in due time when we import the latest BFD? Or do you want me to fix this on both branches? Joel? > Eli> The other issue is with the new stuff in nat/windows-nat.c. Here are > Eli> the compilation error messages: > ... > Eli> This happens because these two symbols are not visible when compiling > Eli> GDB with _WIN32_WINNT set to an older version that Windows 8. The > Eli> patch for this is below. OK to commit it on the master branch? > > This is ok. Thank you. Thanks, will install soon.