From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id 1C0E33858D37
 for <gdb-patches@sourceware.org>; Thu,  6 Oct 2022 17:32:40 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1C0E33858D37
Received: from fencepost.gnu.org ([2001:470:142:3::e]:48646)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1ogUjf-0001nl-II; Thu, 06 Oct 2022 13:32:39 -0400
Received: from [87.69.77.57] (port=3286 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1ogUjd-0000g7-Rh; Thu, 06 Oct 2022 13:32:38 -0400
Date: Thu, 06 Oct 2022 20:32:35 +0300
Message-Id: <83bkqoq2mk.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
In-Reply-To: <9871275a989ff2c262ea9c94e3172c7eabfe7957.1665076921.git.aburgess@redhat.com>
 (message from Andrew Burgess via Gdb-patches on Thu, 6 Oct 2022
 18:23:45 +0100)
Subject: Re: [PATCH 3/3] gdb: add infcall specific debugging
References: <cover.1665076921.git.aburgess@redhat.com>
 <9871275a989ff2c262ea9c94e3172c7eabfe7957.1665076921.git.aburgess@redhat.com>
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Oct 2022 17:32:41 -0000

> Date: Thu,  6 Oct 2022 18:23:45 +0100
> From: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
> 
> diff --git a/gdb/NEWS b/gdb/NEWS
> index 796a4ef8072..8b519a648f7 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -111,6 +111,10 @@ maintenance print frame-id [ LEVEL ]
>    Print GDB's internal frame-id for the frame at LEVEL.  If LEVEL is
>    not given, then print the frame-id for the currently selected frame.
>  
> +set debug infcall on|off
> +show debug infcall
> +  Print additional debug messages about inferior function calls.
> +

This part is OK.

> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -27587,6 +27587,13 @@
>  @item show debug infrun
>  Displays the current state of @value{GDBN} inferior debugging.
>  
> +@item set debug infcall
> +@cindex inferior function call debugging info
> +Turns on or off display of debugging info related to when @value{GDBN}
> +makes inferior function calls.

Is the "related to when" part accurate?  It seems to imply that we
only display indications of such calls, whereas the code seems to do
much more: it shows detailed information about the call and its
results.  So maybe reword as follows:

  Turns on or off display of debugging info related to inferior
  function calls made by @value{GDBN}.

Thanks.