From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [209.51.188.92])
 by sourceware.org (Postfix) with ESMTPS id E8EB83858D39
 for <gdb-patches@sourceware.org>; Wed,  6 Jul 2022 13:45:32 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E8EB83858D39
Received: from fencepost.gnu.org ([2001:470:142:3::e]:46166)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1o95LO-0002Aj-LK; Wed, 06 Jul 2022 09:45:31 -0400
Received: from [87.69.77.57] (port=4652 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1o95LN-0004Da-RP; Wed, 06 Jul 2022 09:45:30 -0400
Date: Wed, 06 Jul 2022 16:45:24 +0300
Message-Id: <83bku273t7.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Ari Hannula <ari.hannula@intel.com>
Cc: gdb-patches@sourceware.org, tim.wiederhake@intel.com
In-Reply-To: <20220706133639.114681-2-ari.hannula@intel.com> (message from Ari
 Hannula via Gdb-patches on Wed, 6 Jul 2022 15:36:38 +0200)
Subject: Re: [PATCH v3 1/2] [func_call] Add function-call-history-length
 command to MI.
References: <20220706133639.114681-1-ari.hannula@intel.com>
 <20220706133639.114681-2-ari.hannula@intel.com>
X-Spam-Status: No, score=1.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Jul 2022 13:45:34 -0000

> Date: Wed,  6 Jul 2022 15:36:38 +0200
> From: Ari Hannula via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Tim Wiederhake <tim.wiederhake@intel.com>
> 
> From: Tim Wiederhake <tim.wiederhake@intel.com>
> 
> This allows MI clients like Eclipse to retrieve the length of the function
> call history.
> 
> Adds documentation for the command.
> 
> Adds tests for the command.
> 
> Signed-off-by: Tim Wiederhake <tim.wiederhake@intel.com>
> Signed-off-by: Ari Hannula <ari.hannula@intel.com>
> ---
>  gdb/Makefile.in                               |  1 +
>  gdb/doc/gdb.texinfo                           | 28 ++++++
>  gdb/mi/mi-cmd-record.c                        | 34 +++++++
>  gdb/mi/mi-cmd-record.h                        | 27 ++++++
>  gdb/mi/mi-cmds.c                              |  2 +
>  gdb/mi/mi-cmds.h                              |  1 +
>  gdb/record-btrace.c                           | 12 +++
>  gdb/target-delegates.c                        | 27 ++++++
>  gdb/target.c                                  |  8 ++
>  gdb/target.h                                  |  7 ++
>  .../gdb.mi/mi-function_call_history.c         | 43 +++++++++
>  .../gdb.mi/mi-function_call_history.exp       | 89 +++++++++++++++++++
>  12 files changed, 279 insertions(+)
>  create mode 100644 gdb/mi/mi-cmd-record.c
>  create mode 100644 gdb/mi/mi-cmd-record.h
>  create mode 100644 gdb/testsuite/gdb.mi/mi-function_call_history.c
>  create mode 100644 gdb/testsuite/gdb.mi/mi-function_call_history.exp

Thanks, the documentation part is OK.