From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [209.51.188.92])
 by sourceware.org (Postfix) with ESMTPS id 6D81A3858C60
 for <gdb-patches@sourceware.org>; Thu,  3 Mar 2022 14:02:54 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6D81A3858C60
Received: from [2001:470:142:3::e] (port=50836 helo=fencepost.gnu.org)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nPm2g-0002c8-0e; Thu, 03 Mar 2022 09:02:54 -0500
Received: from [87.69.77.57] (port=2106 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nPm2f-0004LI-EX; Thu, 03 Mar 2022 09:02:53 -0500
Date: Thu, 03 Mar 2022 16:02:52 +0200
Message-Id: <83bkynjfqr.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
In-Reply-To: <20220303124439.GF1212730@redhat.com> (message from Andrew
 Burgess on Thu, 3 Mar 2022 12:44:39 +0000)
Subject: Re: [PATCHv2 2/2] gdb/mi: add --no-connection to MI -add-inferior
 command
References: <OS3PR01MB629131B83CD4E907BCD7F6A2FB3D9@OS3PR01MB6291.jpnprd01.prod.outlook.com>
 <cover.1646221667.git.aburgess@redhat.com>
 <2d926ccc029733a21d4b1483f89b87739e570b29.1646221667.git.aburgess@redhat.com>
 <83pmn4jf8w.fsf@gnu.org> <20220303124439.GF1212730@redhat.com>
X-Spam-Status: No, score=1.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Mar 2022 14:02:55 -0000

> Date: Thu, 3 Mar 2022 12:44:39 +0000
> From: Andrew Burgess <aburgess@redhat.com>
> Cc: gdb-patches@sourceware.org
> 
> > > Date: Wed,  2 Mar 2022 11:57:36 +0000
> > > From: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
> > > Cc: Andrew Burgess <aburgess@redhat.com>
> > > 
> > > +The command response always has a field, @samp{inferior}, whose value
> > > +is the identifier of the thread group corresponding to the new
> > > +inferior.
> > > +
> > > +An additional section field, @samp{connection}, is optional.  This
> > > +field will only exist if the new inferior has a target connection.  If
> > > +this field exists, then its value will be a tuple containing the
> > > +following fields:
> > 
> > The above two @samp should be @var, since they aren't literal symbols.
> > 
> > OK with that fixed, thanks.
> > 
> > Shouldn't this have a NEWS entry?
> 
> Good point.  The patch below has the @samp -> @var change, plus a NEWS
> entry.

LGTM, thanks.