Re: [PATCH v3] gdb: Add new 'print nibbles' feature

[Eli Zaretskii <eliz@gnu.org>]

> Date: Wed, 25 Aug 2021 21:24:16 +0800
> From: Enze Li via Gdb-patches <gdb-patches@sourceware.org>
> 
> Make an introduction of a new print setting that can be set by 'set
> print nibbles [on|off].  The default value is OFF, and it would be
> changed by users manually.
> 
> And of course, 'show print nibbles' is also included in the patch.
> 
> The new feature could display binary values in groups, and each group
> has four bits.

Thanks.

>   (gdb) print/t a
>   $3 = 100 1100 1110

Wouldn't it be better to show

    $3 = 0100 1100 1110

instead?

> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -135,6 +135,11 @@ set debug event-loop
>  show debug event-loop
>    Control the display of debug output about GDB's event loop.
>  
> +set print nibbles [on|off]
> +show print nibbles
> +  This controls whether the 'print/t' command will display binary values
> +  in groups of four bits, known as "nibbles".  The default is 'off'.
> +

This part is OK.

> +@item -nibbles [@code{on}|@code{off}]
> +Set whether to print binary values in groups of four bits, known
> +as "nibbles". 
      ^^^^^^^^^
``nibbles'', please, to produce nicer quotes.

>                Related setting: @ref{set print nibbles}.

A lone "@ref" is seldom a good idea, except in the HTML output.
Suggest to say just @xref{set print nibbles}, without the "Related
setting" part.

> +@anchor{set print nibbles}
> +@item set print nibbles
> +@itemx set print nibbles on
> +Print binary values in groups of four bits, known as "nibbles",  when
                                                        ^^^^^^^^^
Here, I'd use @dfn{nibbles} instead of quotes, and add a @cindex for
"nibbles".

> +@item set print nibbles off
> +Stop printing binary values in groups.  This is the default.

I'd say "Don't" instead of "Stop".

Thanks.