From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 1EC1639484BB for ; Tue, 1 Jun 2021 12:08:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1EC1639484BB Received: from fencepost.gnu.org ([2001:470:142:3::e]:54146) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lo3CS-0001B3-Mk; Tue, 01 Jun 2021 08:08:48 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2503 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lo3CS-00014L-9h; Tue, 01 Jun 2021 08:08:48 -0400 Date: Tue, 01 Jun 2021 15:08:35 +0300 Message-Id: <83bl8p23ek.fsf@gnu.org> From: Eli Zaretskii To: Zied Guermazi Cc: gdb-patches@sourceware.org, markus.t.metzger@intel.com In-Reply-To: <20210531213307.275079-7-zied.guermazi@trande.de> (message from Zied Guermazi on Mon, 31 May 2021 23:33:06 +0200) Subject: Re: [PATCH v6 6/7] add support for coresight btrace via remote protocol References: <20210531213307.275079-1-zied.guermazi@trande.de> <20210531213307.275079-7-zied.guermazi@trande.de> X-Spam-Status: No, score=1.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jun 2021 12:08:50 -0000 > From: Zied Guermazi > Date: Mon, 31 May 2021 23:33:06 +0200 > Cc: Zied Guermazi > > This patch extends the remote protocol to use ARM CoreSight traces for btrace. > This patch adds the capabilities enumeration as well as the required protocol > extentions for configuring traces collection, starting and stopping tracing, > and transferring the traces as well as the parameters needed for decoding them. > > gdb/ChangeLog > > * NEWS: list new remote packets for extending btrace > to support using ARM CoreSight Traces. > * btrace.c (check_xml_btrace_version): add version 1.1 > (parse_xml_btrace_etm_config_source_config_cpu_etmv4_config): New. > (parse_xml_btrace_etm_config_source_config_cpu_etmv3_config): New. > (parse_xml_btrace_etm_config_source_config_cpu_etm_config): New. > (parse_xml_btrace_etm_config_source_config): New. > (parse_xml_btrace_etm_config_source_config_end): New > (parse_xml_btrace_etm_config_sink_config): New. > (parse_xml_btrace_etm_raw): New. > (parse_xml_btrace_etm): New. > (parse_xml_btrace_conf_etm): New. > * btrace.dtd: add etm data and decoding parameters. > * btrace-conf.dtd: add etm configuration. > * remote.c (remote_target::btrace_sync_conf): add etm configuration. > (remote_target::remote_btrace_maybe_reopen): warn if ETM was disabled. > (remote_target::enable_btrace): add coresight etm. > (_initialize_remote): add etm related packets. > > gdb/doc/ChangeLog > > * gdb.texinfo (General Query Packets) Document extending GDB remote > protocol packets to support using ARM CoreSight traces for btrace. > > gdbserver/ChangeLog > > * configure.srv: add btrace for aarch64*-*-linux* and arm*-*-linux*. > * linux-low.c (linux_low_encode_etm_config): New. > (linux_process_target::read_btrace): encode CoreSight traces > and related decoding parameters. > (linux_process_target::read_btrace_conf): encode CoreSight > configuration. > * server.cc (handle_btrace_enable_etm): New. > (handle_btrace_general_set): add etm handling. > (handle_btrace_conf_general_set): add etm handling. > (supported_btrace_packets): add etm related packets. Likewise here: if there were no changes since v5 in the documentation parts, I believe I already approved that. Thanks.