From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id 94BAC3857C48
 for <gdb-patches@sourceware.org>; Wed, 19 May 2021 11:44:32 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 94BAC3857C48
Received: from fencepost.gnu.org ([2001:470:142:3::e]:45502)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1ljKcq-0002Gk-5W; Wed, 19 May 2021 07:44:32 -0400
Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2365
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1ljKcp-0001kM-A5; Wed, 19 May 2021 07:44:32 -0400
Date: Wed, 19 May 2021 14:44:38 +0300
Message-Id: <83bl97q76h.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
In-Reply-To: <262bab9f91a72af816095a01628e7cd9ac3e48ba.1621421987.git.andrew.burgess@embecosm.com>
 (message from Andrew Burgess on Wed, 19 May 2021 12:12:41 +0100)
Subject: Re: [PATCHv2 4/5] gdb/mi: add new --group-by-objfile flag for
 -file-list-exec-source-files
References: <cover.1619456691.git.andrew.burgess@embecosm.com>
 <cover.1621421987.git.andrew.burgess@embecosm.com>
 <262bab9f91a72af816095a01628e7cd9ac3e48ba.1621421987.git.andrew.burgess@embecosm.com>
X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, GIT_PATCH_0,
 KAM_DMARC_STATUS, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 19 May 2021 11:44:34 -0000

> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Wed, 19 May 2021 12:12:41 +0100
> 
> diff --git a/gdb/NEWS b/gdb/NEWS
> index aae0d5b025a..77dd2fac082 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -46,7 +46,9 @@
>      all locations of the selected breakpoint.  This is equivalent to
>      the '-force' flag of the CLI's "cond" command.
>  
> - ** '-file-list-exec-source-files [--basename | --dirname] [--] [REGEXP]'
> + ** '-file-list-exec-source-files [--group-by-objfile]
> + 	                          [--basename | --dirname]
> +                                  [--] [REGEXP]'
>  
>      The existing -file-list-exec-source-files command now takes an
>      optional REGEXP which is used to filter the source files that are
> @@ -56,6 +58,11 @@
>      When one of --basename or --dirname is given then REGEXP is only
>      matched against the specified part of the full source filename.
>  
> +    When the optional --group-by-objfile flag is used the output
> +    format is changed, the results are now a list of object files
> +    (executable and libraries) with the source files that are
> +    associated with each object file.
> +
>      The results from -file-list-exec-source-files now include a
>      'debug-fully-read' field which takes the value 'true' or 'false'.
>      A 'true' value indicates the source file is from a compilation

This part is OK.

> +If @code{--group-by-objfile} is used then the format of the results is
> +changed.  The results will now be a list of tuples, with each tuple
> +representing an object file (executable or shared libraries) loaded
                                                     ^^^^^^^^^
"library", in singular.  Other than that, the patch for the manual is
also OK.

Thanks.