From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTP id 5C339385E82C
 for <gdb-patches@sourceware.org>; Mon, 16 Mar 2020 17:46:27 +0000 (GMT)
Received: from fencepost.gnu.org ([2001:470:142:3::e]:47103)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
 id 1jDton-0007EU-8I; Mon, 16 Mar 2020 13:46:25 -0400
Received: from [176.228.60.248] (port=2101 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1jDtok-0004nT-KU; Mon, 16 Mar 2020 13:46:24 -0400
Date: Mon, 16 Mar 2020 19:46:22 +0200
Message-Id: <83blowb3bl.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org, jon.turney@dronecode.org.uk
In-Reply-To: <20200316170845.184386-1-simon.marchi@polymtl.ca> (message from
 Simon Marchi on Mon, 16 Mar 2020 13:08:38 -0400)
Subject: Re: [PATCH 0/7] Add "Windows" OS ABI
References: <20200316170845.184386-1-simon.marchi@polymtl.ca>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Spam-Status: No, score=0.0 required=5.0 tests=KAM_DMARC_STATUS,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,
 SPF_PASS autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <http://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Mar 2020 17:46:28 -0000

> From: Simon Marchi <simon.marchi@polymtl.ca>
> Cc: Eli Zaretskii <eliz@gnu.org>,
> 	Jon Turney <jon.turney@dronecode.org.uk>,
> 	Simon Marchi <simon.marchi@polymtl.ca>
> Date: Mon, 16 Mar 2020 13:08:38 -0400
> 
> This patchset started out as a single patch to have the OS ABI Cygwin
> applied to Windows x86-64 binaries, here:
> 
>     https://sourceware.org/legacy-ml/gdb-patches/2020-03/msg00195.html
> 
> with the follow-up here:
> 
>     https://sourceware.org/pipermail/gdb-patches/2020-March/000022.html
> 
> Eli pointed out that it doesn't make sense for binaries compilied with
> MinGW to have the Cygwin OS ABI, that there should be separate OS ABIs
> for Cygwin and non-Cygwin Windows binaries.  This already came up in the
> following bug report:
> 
>     https://sourceware.org/bugzilla/show_bug.cgi?id=21500#add_comment
> 
> This patchset does a bit of refactor in that area.  Most importantly, it:
> 
> - adds a "Windows" OS ABI
> - makes GDB recognize the proper OS ABI (Cygwin or Windows) when
>   loading executables
> - makes the builtin long type on Cygwin be 64 bits long

Thanks for working on this, the changes LGTM.