From: Eli Zaretskii <eliz@gnu.org>
To: John Baldwin <jhb@FreeBSD.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/5] Add a new 'info proc files' subcommand of 'info proc'.
Date: Sat, 08 Sep 2018 06:49:00 -0000 [thread overview]
Message-ID: <83bm98trel.fsf@gnu.org> (raw)
In-Reply-To: <20180908003659.37482-3-jhb@FreeBSD.org> (message from John Baldwin on Fri, 7 Sep 2018 17:36:56 -0700)
> From: John Baldwin <jhb@FreeBSD.org>
> Date: Fri, 7 Sep 2018 17:36:56 -0700
>
> This command displays a list of open file descriptors.
Thanks.
> + add_cmd ("files", class_info, info_proc_cmd_files, _("\
> +List of open files."),
IMO, this doc strings is too terse. I suggest to expand it telling
that the command shows the files open by the process being debugged.
next prev parent reply other threads:[~2018-09-08 6:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-08 0:38 [PATCH 0/5] Add a new 'info proc files' command John Baldwin
2018-09-08 0:38 ` [PATCH 1/5] Use KF_PATH to verify the size of a struct kinfo_file John Baldwin
2018-09-08 22:25 ` Simon Marchi
2018-09-08 0:38 ` [PATCH 3/5] Add support for 'info proc files' on FreeBSD core dumps John Baldwin
2018-09-08 22:54 ` Simon Marchi
2018-09-10 19:37 ` John Baldwin
2018-09-13 15:08 ` Tom Tromey
2018-09-13 18:42 ` John Baldwin
2018-09-08 0:38 ` [PATCH 2/5] Add a new 'info proc files' subcommand of 'info proc' John Baldwin
2018-09-08 6:49 ` Eli Zaretskii [this message]
2018-09-08 22:31 ` Simon Marchi
2018-09-09 5:23 ` Eli Zaretskii
2018-09-10 18:43 ` John Baldwin
2018-09-10 19:11 ` Eli Zaretskii
2018-09-08 22:32 ` Simon Marchi
2018-09-08 0:46 ` [PATCH 5/5] Document the 'info proc files' command John Baldwin
2018-09-08 7:01 ` Eli Zaretskii
2018-09-10 18:43 ` John Baldwin
2018-09-10 19:13 ` Eli Zaretskii
2018-09-10 18:52 ` John Baldwin
2018-09-08 0:46 ` [PATCH 4/5] Support 'info proc files' on live FreeBSD processes John Baldwin
2018-09-08 23:01 ` Simon Marchi
2018-09-10 18:30 ` John Baldwin
2018-09-10 19:03 ` Simon Marchi
2018-09-12 22:38 ` John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bm98trel.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).