public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Fix "set" handling of Python parameters
Date: Fri, 27 Apr 2018 06:42:00 -0000	[thread overview]
Message-ID: <83bme5up4i.fsf@gnu.org> (raw)
In-Reply-To: <20180426225140.18640-1-tom@tromey.com> (message from Tom Tromey	on Thu, 26 Apr 2018 16:51:40 -0600)

> From: Tom Tromey <tom@tromey.com>
> Cc: Tom Tromey <tom@tromey.com>
> Date: Thu, 26 Apr 2018 16:51:40 -0600
> 
> +* Python API
> +
> +  ** A gdb.Parameter will no longer print the "set" help text on an
> +     ordinary "set"; instead by default a "set" will be silent unless
> +     the get_set_string method returns a non-empty string.

The code mentions compatibility with GDB < 7.3, so shouldn't NEWS at
least indicate that this breaks that compatibility?

> +If this method exists, @value{GDBN} will call it when a
> +@var{parameter}'s value has been changed via the @code{set} API (for
> +example, @kbd{set foo off}).  The @code{value} attribute has already
> +been populated with the new value and may be used in output.  This
> +method must return a string.  If the returned string is not empty,
> +@value{GDBN} will present it to the user.

So there's no way for a Python extension to display an empty string,
even if it wants to do that?

Anyway, the documentation parts are approved.  Thanks.

  reply	other threads:[~2018-04-27  6:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-26 22:51 Tom Tromey
2018-04-27  6:42 ` Eli Zaretskii [this message]
2018-04-30 13:01 ` Phil Muldoon
2018-05-25 17:34 ` Tom Tromey
2018-05-30 23:16 ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83bme5up4i.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).