From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105123 invoked by alias); 21 Nov 2017 16:50:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 104646 invoked by uid 89); 21 Nov 2017 16:50:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KB_WAM_FROM_NAME_SINGLEWORD,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Nov 2017 16:50:52 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eHBl0-0007Eo-Cx for gdb-patches@sourceware.org; Tue, 21 Nov 2017 11:50:51 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41014) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eHBl0-0007Ec-1m; Tue, 21 Nov 2017 11:50:46 -0500 Received: from [176.228.60.248] (port=3785 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eHBkz-000268-0l; Tue, 21 Nov 2017 11:50:45 -0500 Date: Tue, 21 Nov 2017 16:50:00 -0000 Message-Id: <83bmjvd19e.fsf@gnu.org> From: Eli Zaretskii To: Sergio Durigan Junior CC: gdb-patches@sourceware.org In-reply-to: <20171121160709.23248-1-sergiodj@redhat.com> (message from Sergio Durigan Junior on Tue, 21 Nov 2017 11:07:09 -0500) Subject: Re: [PATCH] Implement pahole-like 'ptype /o' option Reply-to: Eli Zaretskii References: <20171121160709.23248-1-sergiodj@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00445.txt.bz2 > From: Sergio Durigan Junior > Cc: Sergio Durigan Junior > Date: Tue, 21 Nov 2017 11:07:09 -0500 > > gdb/NEWS | 3 + > gdb/c-typeprint.c | 144 ++++++++++++++++++++++++++++--- > gdb/doc/gdb.texinfo | 4 + > gdb/testsuite/gdb.base/ptype-offsets.cc | 77 +++++++++++++++++ > gdb/testsuite/gdb.base/ptype-offsets.exp | 52 +++++++++++ > gdb/typeprint.c | 8 +- > gdb/typeprint.h | 3 + > 7 files changed, 276 insertions(+), 15 deletions(-) > create mode 100644 gdb/testsuite/gdb.base/ptype-offsets.cc > create mode 100644 gdb/testsuite/gdb.base/ptype-offsets.exp The documentation parts are okay, but ... > +@item o > +Print the offsets and sizes of fields in a struct, similar to what the > +@command{pahole} tool does. ... how about an example showing the output of this? I, for one, have never heard of 'pahole', so the reference to it won't help the likes of myself to understand what will be produced. And here: > + /o print offsets and sizes of fields in a struct (like pahole)\n")); I wonder whether we should mention 'pahole' at all. Thanks.