From: Eli Zaretskii <eliz@gnu.org>
To: gdb-patches@sourceware.org
Subject: Off-by-one error in windows-nat.c causes abort at startup
Date: Sat, 30 Apr 2016 11:08:00 -0000 [thread overview]
Message-ID: <83bn4rpd6m.fsf@gnu.org> (raw)
I created a gdb.ini file in my home directory, and suddenly found that
almost all my GDB binaries stopped working. Even "gdb --version"
would crash at startup thusly:
./common/common-utils.c:141: internal-error: xsnprintf: Assertion `ret < size' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Quit this debugging session? (y or n) [answered Y; input not from terminal]
This is a bug, please report it. For instructions, see:
<http://www.gnu.org/software/gdb/bugs/>.
./common/common-utils.c:141: internal-error: xsnprintf: Assertion `ret < size' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Create a core file of GDB? (y or n) [answered Y; input not from terminal]
This application has requested the Runtime to terminate it in an unusual way.
Please contact the application's support team for more information.
Luckily, I still had GDB 7.5, which did work. Using it, I found the
off-by-one gotcha below (".gdbinit" is one character longer than
"gdb.ini"). I guess no one tested this feature when we switched from
using snprintf to xsnprintf...
OK to commit (with a suitable ChangeLog entry, of course)?
--- gdb/windows-nat.c~ 2016-02-10 05:19:39.000000000 +0200
+++ gdb/windows-nat.c 2016-04-30 11:57:08.500000000 +0300
@@ -2711,9 +2711,9 @@ _initialize_check_for_gdb_ini (void)
if (access (oldini, 0) == 0)
{
int len = strlen (oldini);
- char *newini = (char *) alloca (len + 1);
+ char *newini = (char *) alloca (len + 2);
- xsnprintf (newini, len + 1, "%.*s.gdbinit",
+ xsnprintf (newini, len + 2, "%.*s.gdbinit",
(int) (len - (sizeof ("gdb.ini") - 1)), oldini);
warning (_("obsolete '%s' found. Rename to '%s'."), oldini, newini);
}
next reply other threads:[~2016-04-30 11:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-30 11:08 Eli Zaretskii [this message]
2016-05-02 11:50 ` Pedro Alves
2016-05-02 16:40 ` Eli Zaretskii
2016-05-02 18:01 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bn4rpd6m.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).