public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: jose.marchesi@oracle.com (Jose E. Marchesi)
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 8/9] Documentation for DTrace USDT probes.
Date: Mon, 29 Sep 2014 13:35:00 -0000	[thread overview]
Message-ID: <83bnpymtwl.fsf@gnu.org> (raw)
In-Reply-To: <87wq8m7m69.fsf@oracle.com>

> From: jose.marchesi@oracle.com (Jose E. Marchesi)
> Cc: gdb-patches@sourceware.org
> Date: Mon, 29 Sep 2014 12:31:26 +0200
> 
>     
>     > +Some @code{SystemTap} probes have an associated semaphore variable;
>     > +for instance, this happens automatically if you defined your probe
>     > +using a DTrace-style @file{.d} file.  If your probe has a semaphore,
>     > +@value{GDBN} will automatically enable it when you specify a
>     > +breakpoint using the @samp{-probe-stap} notation.  But, if you put a
>     > +breakpoint at a probe's location by some other method (e.g.,
>     > +@code{break file:line}), then @value{GDBN} will not automatically set
>     > +the semaphore.  @code{DTrace} probes do not support the notion of
>     > +semaphores.
>     
>     The last sentence confused me: you first explain something that seems
>     to imply semaphores are part of DTrace probes, but then say that they
>     don't support semaphores.  What am I missing?
> 
> The paragraph starts explaining that SystemTap probes may have
> associated semaphore variables, followed by a short description on how
> gdb handles these variables.  That was part of the original
> documentation on SystemTap probes.
> 
> I just added the last sentence to note that DTrace probes do not support
> semaphore variables at all.
> 
> I don't see where the confusion is?

The confusion starts with the fact that "DTrace" is mentioned twice,
the first time in the context of discussing semaphores.

How about the following rewrite:

  Some @code{SystemTap} probes have an associated semaphore variable.
  If your probe has a semaphore, @value{GDBN} will automatically
  enable it when you specify a breakpoint using the @samp{-probe-stap}
  notation.  But, if you put a breakpoint at a probe's location by
  some other method (e.g., @code{break file:line}), then @value{GDBN}
  will not automatically set the semaphore.  @code{DTrace} probes do
  not support semaphore variables associated with them.

>     > +probe being handled.  Some @code{DTrace} probes can be enabled or
>     > +disabled, but @code{SystemTap} probes do not support these notions.
>     
>     Which "notions"?  If you want to say they cannot be disabled, please
>     say so explicitly.
> 
> No, I want to say that SystemTap probes do not even support the notion
> of being enabled or disabled.  That is not quite the same than saying
> that SystemTap probes cannot be disabled: for example some DTrace probes
> cannot be disabled because they are always enabled.

Sorry, I don't see the difference between "cannot be disabled" and
"don't support the notion of being enabled or disabled".  A trap that
cannot be disabled is by definition always enabled, right?  So from
the user point of view, saying they cannot be disabled says it all,
right?

  reply	other threads:[~2014-09-29 13:35 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <no>
2012-04-18  9:27 ` [RFA] Add proper handling for internal functions and STT_GNU_IFUNC symbols in Ada mode Paul Hilfinger
2012-04-18 14:45   ` Joel Brobecker
2012-04-22 15:33   ` [committed] " Paul Hilfinger
2014-09-26  9:43 ` [PATCH 0/9] Add support for DTrace USDT probes to gdb Jose E. Marchesi
2014-09-26  9:43   ` [PATCH 1/9] Adapt `info probes' to support printing probes of different types Jose E. Marchesi
2014-09-29 21:15     ` Sergio Durigan Junior
2014-10-10 16:38       ` Jose E. Marchesi
2014-09-26  9:43   ` [PATCH 2/9] Move `compute_probe_arg' and `compile_probe_arg' to probe.c Jose E. Marchesi
2014-09-30  0:02     ` Sergio Durigan Junior
2014-10-10 16:38       ` Jose E. Marchesi
2014-09-26  9:43   ` [PATCH 4/9] New gdbarch functions: dtrace_probe_argument, dtrace_probe_is_enabled, dtrace_enable_probe, dtrace_disable_probe Jose E. Marchesi
2014-10-02 21:34     ` Sergio Durigan Junior
2014-10-10 16:38       ` Jose E. Marchesi
2014-09-26  9:43   ` [PATCH 7/9] Simple testsuite for DTrace USDT probes Jose E. Marchesi
2014-10-08 19:30     ` Sergio Durigan Junior
2014-10-10 16:38       ` Jose E. Marchesi
2014-09-26  9:43   ` [PATCH 9/9] Announce the DTrace USDT probes support in NEWS Jose E. Marchesi
2014-09-26 13:12     ` Eli Zaretskii
2014-09-29 10:29       ` Jose E. Marchesi
2014-09-26  9:43   ` [PATCH 5/9] New probe type: DTrace USDT probes Jose E. Marchesi
2014-09-26 13:19     ` Eli Zaretskii
2014-10-02 23:19     ` Sergio Durigan Junior
2014-10-10 16:38       ` Jose E. Marchesi
2014-10-10 18:13         ` Sergio Durigan Junior
2014-10-10 18:32           ` Jose E. Marchesi
2014-10-10 18:44             ` Sergio Durigan Junior
2014-09-26  9:43   ` [PATCH 8/9] Documentation for " Jose E. Marchesi
2014-09-26 13:18     ` Eli Zaretskii
2014-09-29 10:26       ` Jose E. Marchesi
2014-09-29 13:35         ` Eli Zaretskii [this message]
2014-09-29 13:53           ` Jose E. Marchesi
2014-09-26  9:43   ` [PATCH 6/9] Support for DTrace USDT probes in x86_64 targets Jose E. Marchesi
2014-10-08 19:32     ` Sergio Durigan Junior
2014-10-10 16:38       ` Jose E. Marchesi
2014-09-26  9:43   ` [PATCH 3/9] New commands `enable probe' and `disable probe' Jose E. Marchesi
2014-09-26 13:11     ` Eli Zaretskii
2014-09-29 10:26       ` Jose E. Marchesi
2014-09-30 23:13     ` Sergio Durigan Junior
2014-09-30 23:20       ` Sergio Durigan Junior
2014-10-10 16:38       ` Jose E. Marchesi
2014-10-08 19:40   ` [PATCH 0/9] Add support for DTrace USDT probes to gdb Sergio Durigan Junior
2014-10-09  8:05     ` Jose E. Marchesi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83bnpymtwl.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jose.marchesi@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).