From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-86916-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18655 invoked by alias); 10 Jan 2012 20:56:28 -0000
Received: (qmail 18643 invoked by uid 22791); 10 Jan 2012 20:56:27 -0000
X-SWARE-Spam-Status: No, hits=-1.3 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 Jan 2012 20:56:13 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LXL00B00OS21E00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Tue, 10 Jan 2012 22:56:12 +0200 (IST)
Received: from HOME-C4E4A596F7 ([84.228.135.112]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LXL00AS8OTN9BD0@a-mtaout22.012.net.il>; Tue, 10 Jan 2012 22:56:12 +0200 (IST)
Date: Tue, 10 Jan 2012 20:58:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: Building GDB 7.3.92 with MinGW
In-reply-to: <m3k44zid81.fsf@fleche.redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83boqbe0pc.fsf@gnu.org>
References: <83hb03e9sx.fsf@gnu.org> <m3k44zid81.fsf@fleche.redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-01/txt/msg00313.txt.bz2

> From: Tom Tromey <tromey@redhat.com>
> Cc: gdb-patches@sourceware.org
> Date: Tue, 10 Jan 2012 12:12:14 -0700
> 
> >>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
> 
> Eli>   Any objections to the following patch?  (If approved, I will add a
> Eli>   comment explaining the problem on Windows which requires this.)
> Eli>      --- gdb/gdb_curses.h~0	2012-01-06 06:43:14.000000000 +0200
> Eli>      +++ gdb/gdb_curses.h	2012-01-10 13:21:10.626119900 +0200
> Eli>      @@ -27,6 +27,9 @@
> Eli>       #elif defined (HAVE_CURSESX_H)
> Eli>       #include <cursesX.h>
> Eli>       #elif defined (HAVE_CURSES_H)
> Eli>      +#if defined(__MINGW32__) && defined(MOUSE_MOVED)
> Eli>      +#undef MOUSE_MOVED
> Eli>      +#endif
> Eli>       #include <curses.h>
> Eli>       #endif
> 
> I don't really mind this patch.  But, why is this something for gdb to
> solve rather than mingw?

Unlikely: it's the problem between PDCurses and the MS-Windows API
header files.

> Eli> 2. "make install-strip" fails in readline/, in sim/, and in gdb/:
> 
> Eli>    The reason is that these directories simply don't have the
> Eli>    "install-strip" target in their Makefile.in files.  I think that
> Eli>    target should be added, because that's AFAIK how GDB is supposed to
> Eli>    be installed on end-user systems.
> 
> This is in the GNU standards, but in practice few people use it.
> 
> Of course, patches are welcome.  This isn't the only places where gdb's
> Makefiles diverge from the standards.

I'll try.