From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14756 invoked by alias); 28 Jan 2011 09:28:45 -0000 Received: (qmail 14748 invoked by uid 22791); 28 Jan 2011 09:28:44 -0000 X-SWARE-Spam-Status: No, hits=-0.7 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 28 Jan 2011 09:28:39 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LFQ00H007EEZP00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Fri, 28 Jan 2011 11:28:31 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.127.46.39]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LFQ00H6R7NGC390@a-mtaout20.012.net.il>; Fri, 28 Jan 2011 11:28:30 +0200 (IST) Date: Fri, 28 Jan 2011 09:39:00 -0000 From: Eli Zaretskii Subject: Re: [RFA] Implement support for PowerPC BookE ranged breakpoints In-reply-to: <1296177985.2843.82.camel@hactar> To: Thiago Jung Bauermann Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83bp31idgm.fsf@gnu.org> References: <1296177985.2843.82.camel@hactar> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00531.txt.bz2 > From: Thiago Jung Bauermann > Date: Thu, 27 Jan 2011 23:26:25 -0200 > > This is (finally!) the last patch in my series to support BookE hardware > debug features. It adds the following command: > > (gdb) help break-range > Set a breakpoint for an address range. > break-range START-LOCATION, END-LOCATION > where START-LOCATION and END-LOCATION can be one of the following: > LINENUM, for that line in the current file, > FILE:LINENUM, for that line in that file, > +OFFSET, for that number of lines after the current line > or the start of the range > FUNCTION, for the first line in that function, > FILE:FUNCTION, to distinguish among like-named static functions. > *ADDRESS, for the instruction at that address. Thanks. > +* When locally debugging programs on PowerPC BookE processors running ^^^^^^^ You mean "natively", right? I don't think we use "local debugging" elsewhere in our documentation, do we? > + a Linux kernel version 2.6.34 or later, GDB supports ranged breakpoints, > + which stop execution of the inferior whenever it executes any address > + within the specified range. See the "PowerPC Embedded" section in the "whenever it executes an instruction at any address within the specified range". (You cannot "execute" an address.) > + if (b->disposition == disp_del) > + printf_filtered (_("Temporary ranged breakpoint")); > + else > + printf_filtered (_("Ranged breakpoint")); > + printf_filtered (_(" %d"), b->number); This snippet violates one of the rules of translation-ready software: don't construct phrases from parts. I suggest to make " %d" part of each of the two possibilities. > +static void > +print_recreate_ranged_breakpoint (struct breakpoint *b, struct ui_file *fp) > +{ > + fprintf_unfiltered (fp, "break-range %s", b->exp_string); Should this string be in _() ? > + sals_start.sals = (struct symtab_and_line *) > + xmalloc (sizeof (struct symtab_and_line)); > + sals_start.nelts = 1; Spaces and TABs mixup alert! > +The breakpoint will stop execution of the inferior whenever it\n\ > +executes any address within the [start-address, end-address] range\n\ ^^^^^^^^^^^^^^^^^^^^ Same correction as in NEWS. > +PowerPC embedded processors support hardware accelerated ranged breakpoints. > +A @dfn{ranged breakpoint} stops execution of the inferior whenever it Use @dfn when you first introduce a term, in this case in the previous sentence. Also, please add here a @cindex entry about "ranged breakpoint". > +executes any address within the range it specifies. To set a ranged ^^^^^^^^^^^^^^^^^^^^ Same correction as in NEWS. > +Set a breakpoint for an address range. > +@var{start-location} and @var{end-location} can specify a function name, > +a line number, an offset of lines from the current line or from the start > +location, or an address of an instruction (@xref{Specify Location}, You want a "see @ref here", not @xref. The latter will produce "See" with a capital S, which will look like a typo. In general, @xref is supposed to use only at the beginning of a sentence. > +The breakpoint will stop execution of the inferior whenever it > +executes any address within the specified range, (including ^^^^^^^^^^^^^^^^^^^^ Same correction as above. The patch for NEWS and the manual is okay with those changes.