From: Wei-min Pan <weimin.pan@oracle.com>
To: Tom Tromey <tom@tromey.com>,
Weimin Pan via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH,V4 2/2] CTF: multi-CU and archive support
Date: Sun, 9 May 2021 20:12:55 -0700 [thread overview]
Message-ID: <83cb2b2f-97be-aa2c-82d2-6be769dbc7bb@oracle.com> (raw)
In-Reply-To: <87eeeh9e72.fsf@tromey.com>
On 5/8/2021 1:13 PM, Tom Tromey wrote:
>>> + for (int i = 0; i < arch_cnt; ++i)
>>> + {
>>> + parent_pst->dependencies[i]
>>> + = pcu.imported_symtabs.at (i);
>>> + }
> I forgot to mention -- don't use .at(), just use [] instead.
> This loop could probably just be a memcpy or a std::copy, though an
> explicit loop is also fine.
OK, thanks.
>
> Tom
next prev parent reply other threads:[~2021-05-10 3:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 1:00 [PATCH,V4 0/2] CTF: bug fixes and new features Weimin Pan
2021-04-27 1:00 ` [PATCH,V4 1/2] CTF: fix incorrect function return type Weimin Pan
2021-04-27 1:00 ` [PATCH,V4 2/2] CTF: multi-CU and archive support Weimin Pan
2021-05-07 20:29 ` Tom Tromey
2021-05-10 3:11 ` Wei-min Pan
2021-05-10 21:27 ` Tom Tromey
2021-05-11 0:33 ` Weimin Pan
2021-05-11 18:58 ` Weimin Pan
2021-05-13 17:21 ` Tom Tromey
2021-05-13 21:40 ` Wei-min Pan
2021-05-08 20:13 ` Tom Tromey
2021-05-10 3:12 ` Wei-min Pan [this message]
2021-05-07 20:07 ` [PATCH,V4 1/2] CTF: fix incorrect function return type Tom Tromey
2021-05-10 2:40 ` Wei-min Pan
2021-05-10 14:00 ` Tom Tromey
2021-05-16 22:31 ` Wei-min Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83cb2b2f-97be-aa2c-82d2-6be769dbc7bb@oracle.com \
--to=weimin.pan@oracle.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).